Commit 92963903 authored Apr 08, 2021 by Pali Rohár Committed by Viresh Kumar Apr 09, 2021

cpufreq: armada-37xx: Fix driver cleanup when registration failed

Commit 8db82563 ("cpufreq: armada-37xx: fix frequency calculation for
opp") changed calculation of frequency passed to the dev_pm_opp_add()
function call. But the code for dev_pm_opp_remove() function call was not
updated, so the driver cleanup phase does not work when registration fails.

This fixes the issue by using the same frequency in both calls.

Signed-off-by: Pali Rohár <pali@kernel.org>
Acked-by: Gregory CLEMENT <gregory.clement@bootlin.com>
Tested-by: Tomasz Maciej Nowak <tmn505@gmail.com>
Tested-by: Anders Trier Olesen <anders.trier.olesen@gmail.com>
Tested-by: Philip Soares <philips@netisense.com>
Fixes: 8db82563 ("cpufreq: armada-37xx: fix frequency calculation for opp")
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>

parent e93033af

drivers/cpufreq/armada-37xx-cpufreq.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -521,7 +521,7 @@ static int __init armada37xx_cpufreq_driver_init(void)
		remove_opp:
		/* clean-up the already added opp before leaving */
		while (load_lvl-- > ARMADA_37XX_DVFS_LOAD_0) {
		freq = cur_frequency / dvfs->divider[load_lvl];
		freq = base_frequency / dvfs->divider[load_lvl];
		dev_pm_opp_remove(cpu_dev, freq);
		}