Commit 94e48d6a authored by Jason Wang's avatar Jason Wang Committed by Michael S. Tsirkin
Browse files

vp_vdpa: correct the return value when fail to map notification 



We forget to assign a error value when we fail to map the notification
during prove. This patch fixes it.

Reported-by: default avatarkernel test robot <lkp@intel.com>
Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Fixes: 11d8ffed ("vp_vdpa: switch to use vp_modern_map_vq_notify()")
Signed-off-by: default avatarJason Wang <jasowang@redhat.com>
Link: https://lore.kernel.org/r/20210624035939.26618-1-jasowang@redhat.com


Reviewed-by: default avatarStefano Garzarella <sgarzare@redhat.com>
Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
parent 3f2869ca

drivers/vdpa/virtio_pci/vp_vdpa.c

+1 −0
Original line number Original line Diff line number Diff line
@@ -442,6 +442,7 @@ static int vp_vdpa_probe(struct pci_dev *pdev, const struct pci_device_id *id) 
			vp_modern_map_vq_notify(mdev, i,

			vp_modern_map_vq_notify(mdev, i,

						&vp_vdpa->vring[i].notify_pa);

						&vp_vdpa->vring[i].notify_pa);

		if (!vp_vdpa->vring[i].notify) {

		if (!vp_vdpa->vring[i].notify) {

			ret = -EINVAL;

			dev_warn(&pdev->dev, "Fail to map vq notify %d\n", i);

			dev_warn(&pdev->dev, "Fail to map vq notify %d\n", i);

			goto err;

			goto err;

		}

		}