Commit 94e9dd43 authored by Pan Bian's avatar Pan Bian Committed by Krzysztof Kozlowski
Browse files

memory: ti-aemif: Drop child node when jumping out loop 



Call of_node_put() to decrement the reference count of the child node
child_np when jumping out of the loop body of
for_each_available_child_of_node(), which is a macro that increments and
decrements the reference count of child node. If the loop is broken, the
reference of the child node should be dropped manually.

Fixes: 5a7c8154 ("memory: ti-aemif: introduce AEMIF driver")
Signed-off-by: default avatarPan Bian <bianpan2016@163.com>
Link: https://lore.kernel.org/r/20210121090359.61763-1-bianpan2016@163.com


Signed-off-by: default avatarKrzysztof Kozlowski <krzk@kernel.org>
parent 18212031

drivers/memory/ti-aemif.c

+6 −2
Original line number Diff line number Diff line
@@ -378,9 +378,11 @@ static int aemif_probe(struct platform_device *pdev) 
		 */

		for_each_available_child_of_node(np, child_np) {

			ret = of_aemif_parse_abus_config(pdev, child_np);

			if (ret < 0)

			if (ret < 0) {

				of_node_put(child_np);

				goto error;

			}

		}

	} else if (pdata && pdata->num_abus_data > 0) {

		for (i = 0; i < pdata->num_abus_data; i++, aemif->num_cs++) {

			aemif->cs_data[i].cs = pdata->abus_data[i].cs;
@@ -405,9 +407,11 @@ static int aemif_probe(struct platform_device *pdev) 
		for_each_available_child_of_node(np, child_np) {

			ret = of_platform_populate(child_np, NULL,

						   dev_lookup, dev);

			if (ret < 0)

			if (ret < 0) {

				of_node_put(child_np);

				goto error;

			}

		}

	} else if (pdata) {

		for (i = 0; i < pdata->num_sub_devices; i++) {

			pdata->sub_devices[i].dev.parent = dev;