Commit 9627944c authored by Jacopo Mondi's avatar Jacopo Mondi Committed by Mauro Carvalho Chehab
Browse files

media: i2c: rdacm20: Fix format definition 



The RDACM20 camera supports a single image format which is currently
listed as MEDIA_BUS_FMT_UYVY8_2X8. As the video stream is transmitted on
the GMSL serial bus, the 2X8 variant does not apply.

Fix the format by using MEDIA_BUS_FMT_UYVY8_1X16.

This fixes a runtime error which is now triggered as the MAX9286
deserializer implements .link_validate().

Signed-off-by: default avatarJacopo Mondi <jacopo+renesas@jmondi.org>
Reviewed-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: default avatarKieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@kernel.org>
parent 78b3f9d7

drivers/media/i2c/rdacm20.c

+4 −4
Original line number Diff line number Diff line
@@ -47,11 +47,11 @@ 
#define OV10635_VTS			933



/*

 * As the drivers supports a single MEDIA_BUS_FMT_UYVY8_2X8 format we

 * As the drivers supports a single MEDIA_BUS_FMT_UYVY8_1X16 format we

 * can harcode the pixel rate.

 *

 * PCLK is fed through the system clock, programmed @88MHz.

 * MEDIA_BUS_FMT_UYVY8_2X8 format = 2 samples per pixel.

 * MEDIA_BUS_FMT_UYVY8_1X16 format = 2 samples per pixel.

 *

 * Pixelrate = PCLK / 2

 * FPS = (OV10635_VTS * OV10635_HTS) / PixelRate
@@ -409,7 +409,7 @@ static int rdacm20_enum_mbus_code(struct v4l2_subdev *sd, 
	if (code->pad || code->index > 0)

		return -EINVAL;



	code->code = MEDIA_BUS_FMT_UYVY8_2X8;

	code->code = MEDIA_BUS_FMT_UYVY8_1X16;



	return 0;

}
@@ -425,7 +425,7 @@ static int rdacm20_get_fmt(struct v4l2_subdev *sd, 


	mf->width		= OV10635_WIDTH;

	mf->height		= OV10635_HEIGHT;

	mf->code		= MEDIA_BUS_FMT_UYVY8_2X8;

	mf->code		= MEDIA_BUS_FMT_UYVY8_1X16;

	mf->colorspace		= V4L2_COLORSPACE_RAW;

	mf->field		= V4L2_FIELD_NONE;

	mf->ycbcr_enc		= V4L2_YCBCR_ENC_601;