Commit 96cf2f54 authored by Ming Lei's avatar Ming Lei Committed by Jens Axboe
Browse files

block: ublk_drv: clean up several helpers 



Convert the following pattern in several helpers
	if (Z)
		return true
	return false
into:
	return Z;

Reviewed-by: default avatarZiyang Zhang <ZiyangZhang@linux.alibaba.com>
Signed-off-by: default avatarMing Lei <ming.lei@redhat.com>
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 2f3af723

drivers/block/ublk_drv.c

+5 −13
Original line number Diff line number Diff line
@@ -298,9 +298,7 @@ static inline bool ublk_can_use_task_work(const struct ublk_queue *ubq) 


static inline bool ublk_need_get_data(const struct ublk_queue *ubq)

{

	if (ubq->flags & UBLK_F_NEED_GET_DATA)

		return true;

	return false;

	return ubq->flags & UBLK_F_NEED_GET_DATA;

}



static struct ublk_device *ublk_get_device(struct ublk_device *ub)
@@ -349,25 +347,19 @@ static inline int ublk_queue_cmd_buf_size(struct ublk_device *ub, int q_id) 
static inline bool ublk_queue_can_use_recovery_reissue(

		struct ublk_queue *ubq)

{

	if ((ubq->flags & UBLK_F_USER_RECOVERY) &&

			(ubq->flags & UBLK_F_USER_RECOVERY_REISSUE))

		return true;

	return false;

	return (ubq->flags & UBLK_F_USER_RECOVERY) &&

			(ubq->flags & UBLK_F_USER_RECOVERY_REISSUE);

}



static inline bool ublk_queue_can_use_recovery(

		struct ublk_queue *ubq)

{

	if (ubq->flags & UBLK_F_USER_RECOVERY)

		return true;

	return false;

	return ubq->flags & UBLK_F_USER_RECOVERY;

}



static inline bool ublk_can_use_recovery(struct ublk_device *ub)

{

	if (ub->dev_info.flags & UBLK_F_USER_RECOVERY)

		return true;

	return false;

	return ub->dev_info.flags & UBLK_F_USER_RECOVERY;

}



static void ublk_free_disk(struct gendisk *disk)