Commit 9773cf1c authored by Jérôme Pouiller's avatar Jérôme Pouiller Committed by Greg Kroah-Hartman
Browse files

staging: wfx: fix warning when unregister a frozen device 



The device does not answer to the command hif_shutdown. Therefore,
hif_shutdown() is a bit special. It bypasses some of work normally made
by wfx_cmd_send(). In particularly, it unlock hif_cmd.lock and
hif_cmd.key_renew_lock.

However, if the driver notice that the device is frozen, wfx_cmd_send()
stops to send data and doesn't lock the mutexes. Then, it produced a
warning when hif_shutdown() tried to unlock these mutexes.

Signed-off-by: default avatarJérôme Pouiller <jerome.pouiller@silabs.com>
Link: https://lore.kernel.org/r/20200515083325.378539-2-Jerome.Pouiller@silabs.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 3abbab51

drivers/staging/wfx/hif_tx.c

+2 −0
Original line number Diff line number Diff line
@@ -131,6 +131,8 @@ int hif_shutdown(struct wfx_dev *wdev) 
	int ret;

	struct hif_msg *hif;



	if (wdev->chip_frozen)

		return 0;

	wfx_alloc_hif(0, &hif);

	wfx_fill_header(hif, -1, HIF_REQ_ID_SHUT_DOWN, 0);

	ret = wfx_cmd_send(wdev, hif, NULL, 0, true);