Commit 9786f8b2 authored by Malcolm Priestley's avatar Malcolm Priestley Committed by Greg Kroah-Hartman
Browse files

staging: vt6656: vnt_usb_send_context remove variable data. 



A limit is also placed in vnt_tx_context of MAX_TOTAL_SIZE_WITH_ALL_HEADERS
limiting size.

Signed-off-by: default avatarMalcolm Priestley <tvboxspy@gmail.com>
Link: https://lore.kernel.org/r/9416e1a8-bd72-ffb1-5366-78361d053907@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 9deca1e3

drivers/staging/vt6656/device.h

+0 −1
Original line number Diff line number Diff line
@@ -250,7 +250,6 @@ struct vnt_usb_send_context { 
	u8 pkt_type;

	u8 need_ack;

	bool in_use;

	unsigned char data[MAX_TOTAL_SIZE_WITH_ALL_HEADERS];

};



/*

drivers/staging/vt6656/rxtx.c

+0 −3
Original line number Diff line number Diff line
@@ -73,9 +73,6 @@ static struct vnt_usb_send_context 
		context = priv->tx_context[ii];

		if (!context->in_use) {

			context->in_use = true;

			memset(context->data, 0,

			       MAX_TOTAL_SIZE_WITH_ALL_HEADERS);



			context->hdr = NULL;



			return context;

drivers/staging/vt6656/usbpipe.c

+5 −0
Original line number Diff line number Diff line
@@ -463,6 +463,11 @@ int vnt_tx_context(struct vnt_private *priv, 
		return -ENODEV;

	}



	if (context->buf_len > MAX_TOTAL_SIZE_WITH_ALL_HEADERS) {

		context->in_use = false;

		return -E2BIG;

	}



	usb_fill_bulk_urb(urb,

			  priv->usb,

			  usb_sndbulkpipe(priv->usb, 3),