Commit 983a1a30 authored by Alex Elder's avatar Alex Elder Committed by David S. Miller
Browse files

net: ipa: simplify endpoint transaction completion 



When a GSI transaction completes, ipa_endpoint_trans_complete() is
eventually called.  That handles TX and RX completions separately,
but ipa_endpoint_tx_complete() is a no-op.

Instead, have ipa_endpoint_trans_complete() return immediately for a
TX transaction, and incorporate code from ipa_endpoint_rx_complete()
to handle RX transactions.

Signed-off-by: default avatarAlex Elder <elder@linaro.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 317595d2

drivers/net/ipa/ipa_endpoint.c

+5 −18
Original line number Diff line number Diff line
@@ -1368,18 +1368,14 @@ static void ipa_endpoint_status_parse(struct ipa_endpoint *endpoint, 
	}

}



/* Complete a TX transaction, command or from ipa_endpoint_skb_tx() */

static void ipa_endpoint_tx_complete(struct ipa_endpoint *endpoint,

				     struct gsi_trans *trans)

{

}



/* Complete transaction initiated in ipa_endpoint_replenish_one() */

static void ipa_endpoint_rx_complete(struct ipa_endpoint *endpoint,

void ipa_endpoint_trans_complete(struct ipa_endpoint *endpoint,

				 struct gsi_trans *trans)

{

	struct page *page;



	if (endpoint->toward_ipa)

		return;



	if (trans->cancelled)

		goto done;
@@ -1393,15 +1389,6 @@ static void ipa_endpoint_rx_complete(struct ipa_endpoint *endpoint, 
	ipa_endpoint_replenish(endpoint);

}



void ipa_endpoint_trans_complete(struct ipa_endpoint *endpoint,

				 struct gsi_trans *trans)

{

	if (endpoint->toward_ipa)

		ipa_endpoint_tx_complete(endpoint, trans);

	else

		ipa_endpoint_rx_complete(endpoint, trans);

}



void ipa_endpoint_trans_release(struct ipa_endpoint *endpoint,

				struct gsi_trans *trans)

{