Commit 996e1def authored by Jagan Teki's avatar Jagan Teki Committed by Marek Vasut
Browse files

drm: exynos: dsi: Fix MIPI_DSI*_NO_* mode flags 



HFP/HBP/HSA/EOT_PACKET modes in Exynos DSI host specifies
0 = Enable and 1 = Disable.

The logic for checking these mode flags was correct before
the MIPI_DSI*_NO_* mode flag conversion.

This patch is trying to fix this MIPI_DSI*_NO_* mode flags handling
Exynos DSI host and update the mode_flags in relevant panel drivers.

Fixes: 0f3b68b6 ("drm/dsi: Add _NO_ to MIPI_DSI_* flags disabling features")
Reviewed-by: default avatarMarek Vasut <marex@denx.de>
Reviewed-by: default avatarNicolas Boichat <drinkcat@chromium.org>
Reported-by: default avatarSébastien Szymanski <sebastien.szymanski@armadeus.com>
Signed-off-by: default avatarJagan Teki <jagan@amarulasolutions.com>
Reviewed-by: default avatarFrieder Schrempf <frieder.schrempf@kontron.de>
Signed-off-by: default avatarMarek Vasut <marex@denx.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20221212145745.15387-1-jagan@amarulasolutions.com
parent ce1fc502

drivers/gpu/drm/exynos/exynos_drm_dsi.c

+4 −4
Original line number Diff line number Diff line
@@ -805,15 +805,15 @@ static int exynos_dsi_init_link(struct exynos_dsi *dsi) 
			reg |= DSIM_AUTO_MODE;

		if (dsi->mode_flags & MIPI_DSI_MODE_VIDEO_HSE)

			reg |= DSIM_HSE_MODE;

		if (!(dsi->mode_flags & MIPI_DSI_MODE_VIDEO_NO_HFP))

		if (dsi->mode_flags & MIPI_DSI_MODE_VIDEO_NO_HFP)

			reg |= DSIM_HFP_MODE;

		if (!(dsi->mode_flags & MIPI_DSI_MODE_VIDEO_NO_HBP))

		if (dsi->mode_flags & MIPI_DSI_MODE_VIDEO_NO_HBP)

			reg |= DSIM_HBP_MODE;

		if (!(dsi->mode_flags & MIPI_DSI_MODE_VIDEO_NO_HSA))

		if (dsi->mode_flags & MIPI_DSI_MODE_VIDEO_NO_HSA)

			reg |= DSIM_HSA_MODE;

	}



	if (!(dsi->mode_flags & MIPI_DSI_MODE_NO_EOT_PACKET))

	if (dsi->mode_flags & MIPI_DSI_MODE_NO_EOT_PACKET)

		reg |= DSIM_EOT_DISABLE;



	switch (dsi->format) {

drivers/gpu/drm/panel/panel-samsung-s6e3ha2.c

+3 −1
Original line number Diff line number Diff line
@@ -692,7 +692,9 @@ static int s6e3ha2_probe(struct mipi_dsi_device *dsi) 


	dsi->lanes = 4;

	dsi->format = MIPI_DSI_FMT_RGB888;

	dsi->mode_flags = MIPI_DSI_CLOCK_NON_CONTINUOUS;

	dsi->mode_flags = MIPI_DSI_CLOCK_NON_CONTINUOUS |

		MIPI_DSI_MODE_VIDEO_NO_HFP | MIPI_DSI_MODE_VIDEO_NO_HBP |

		MIPI_DSI_MODE_VIDEO_NO_HSA | MIPI_DSI_MODE_NO_EOT_PACKET;



	ctx->supplies[0].supply = "vdd3";

	ctx->supplies[1].supply = "vci";

drivers/gpu/drm/panel/panel-samsung-s6e63j0x03.c

+2 −1
Original line number Diff line number Diff line
@@ -446,7 +446,8 @@ static int s6e63j0x03_probe(struct mipi_dsi_device *dsi) 


	dsi->lanes = 1;

	dsi->format = MIPI_DSI_FMT_RGB888;

	dsi->mode_flags = MIPI_DSI_MODE_NO_EOT_PACKET;

	dsi->mode_flags = MIPI_DSI_MODE_VIDEO_NO_HFP |

		MIPI_DSI_MODE_VIDEO_NO_HBP | MIPI_DSI_MODE_VIDEO_NO_HSA;



	ctx->supplies[0].supply = "vdd3";

	ctx->supplies[1].supply = "vci";

drivers/gpu/drm/panel/panel-samsung-s6e8aa0.c

+0 −2
Original line number Diff line number Diff line
@@ -990,8 +990,6 @@ static int s6e8aa0_probe(struct mipi_dsi_device *dsi) 
	dsi->lanes = 4;

	dsi->format = MIPI_DSI_FMT_RGB888;

	dsi->mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_BURST

		| MIPI_DSI_MODE_VIDEO_NO_HFP | MIPI_DSI_MODE_VIDEO_NO_HBP

		| MIPI_DSI_MODE_VIDEO_NO_HSA | MIPI_DSI_MODE_NO_EOT_PACKET

		| MIPI_DSI_MODE_VSYNC_FLUSH | MIPI_DSI_MODE_VIDEO_AUTO_VERT;



	ret = s6e8aa0_parse_dt(ctx);