Unverified Commit 9ad6f181 authored by Javier Martinez Canillas's avatar Javier Martinez Canillas
Browse files

drm/st7735r: Fix module autoloading for Okaya RH128128T 



The SPI core always reports a "MODALIAS=spi:<foo>", even if the device was
registered via OF. This means that the st7735r.ko module won't autoload if
a DT has a node with a compatible "okaya,rh128128t" string.

In that case, kmod expects a "MODALIAS=of:N*T*Cokaya,rh128128t" uevent but
instead will get a "MODALIAS=spi:rh128128t", which is not present in the
list of aliases:

  $ modinfo drivers/gpu/drm/tiny/st7735r.ko | grep alias
  alias:          of:N*T*Cokaya,rh128128tC*
  alias:          of:N*T*Cokaya,rh128128t
  alias:          of:N*T*Cjianda,jd-t18003-t01C*
  alias:          of:N*T*Cjianda,jd-t18003-t01
  alias:          spi:jd-t18003-t01

To workaround this issue, add in the SPI table an entry for that device.

Fixes: d1d511d5 ("drm: tiny: st7735r: Add support for Okaya RH128128T")
Signed-off-by: default avatarJavier Martinez Canillas <javierm@redhat.com>
Reviewed-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
Acked-by: default avatarDavid Lechner <david@lechnology.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220520091602.179078-1-javierm@redhat.com
parent 649eb382

drivers/gpu/drm/tiny/st7735r.c

+1 −0
Original line number Diff line number Diff line
@@ -174,6 +174,7 @@ MODULE_DEVICE_TABLE(of, st7735r_of_match); 


static const struct spi_device_id st7735r_id[] = {

	{ "jd-t18003-t01", (uintptr_t)&jd_t18003_t01_cfg },

	{ "rh128128t", (uintptr_t)&rh128128t_cfg },

	{ },

};

MODULE_DEVICE_TABLE(spi, st7735r_id);