Commit 9b00a5f5 authored by Ziyang Xuan's avatar Ziyang Xuan Committed by Guenter Roeck
Browse files

hwmon: (occ) Delete unnecessary NULL check 



kvfree(NULL) is safe. NULL check before kvfree() is not needed.
Delete them to simplify the code.

Generated by coccinelle script:
	scripts/coccinelle/free/ifnullfree.cocci

Signed-off-by: default avatarZiyang Xuan <william.xuanziyang@huawei.com>
Reviewed-by: default avatarEddie James <eajames@linux.ibm.com>
Link: https://lore.kernel.org/r/20220606131401.4053036-1-william.xuanziyang@huawei.com


Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent f9938eeb

drivers/hwmon/occ/p9_sbe.c

+2 −4
Original line number Diff line number Diff line
@@ -55,7 +55,6 @@ static bool p9_sbe_occ_save_ffdc(struct p9_sbe_occ *ctx, const void *resp, 
	mutex_lock(&ctx->sbe_error_lock);

	if (!ctx->sbe_error) {

		if (resp_len > ctx->ffdc_size) {

			if (ctx->ffdc)

			kvfree(ctx->ffdc);

			ctx->ffdc = kvmalloc(resp_len, GFP_KERNEL);

			if (!ctx->ffdc) {
@@ -170,7 +169,6 @@ static int p9_sbe_occ_remove(struct platform_device *pdev) 
	ctx->sbe = NULL;

	occ_shutdown(occ);



	if (ctx->ffdc)

	kvfree(ctx->ffdc);



	return 0;