Commit 9b791d47 authored by Hirokazu Takata's avatar Hirokazu Takata Committed by Linus Torvalds
Browse files

[PATCH] m32r: Fix M32104 cache flushing routines 



This patch fixes cache memory parameter setting for the M32104 target.  So
far, its performance seemed to have been degraded due to incorrect cache
parameter setting.

  * arch/m32r/boot/setup.S: Set SFR(Special Fuction Registers) region
    to be non-cachable explicitly.
  * arch/m32r/mm/cache.c: Fix cache flushing routines not to switch off
    the M32104 cache.

Signed-off-by: default avatarHayato Fujiwara <fujiwara@linux-m32r.org>
Signed-off-by: default avatarHirokazu Takata <takata@linux-m32r.org>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent 46ea178b

arch/m32r/boot/setup.S

+12 −3
Original line number Diff line number Diff line 
/*

 *  linux/arch/m32r/boot/setup.S -- A setup code.

 *

 *  Copyright (C) 2001, 2002  Hiroyuki Kondo, Hirokazu Takata,

 *  and Hitoshi Yamamoto

 *  Copyright (C) 2001-2005   Hiroyuki Kondo, Hirokazu Takata,

 *                            Hitoshi Yamamoto, Hayato Fujiwara

 *

 */

/* $Id$ */



#include <linux/linkage.h>

#include <asm/segment.h>
@@ -81,6 +80,16 @@ ENTRY(boot) 
;	ldi	r1, #0x00		; cache off

	st	r1, @r0

#elif defined(CONFIG_CHIP_M32104)

	ldi	r0, #-96		; DNCR0

	seth	r1, #0x0060		;  from 0x00600000

	or3	r1, r1, #0x0005		;  size 2MB

	st	r1, @r0

	seth	r1, #0x0100		;  from 0x01000000

	or3	r1, r1, #0x0003		;  size 16MB

	st	r1, @+r0

	seth	r1, #0x0200		;  from 0x02000000

	or3	r1, r1, #0x0002		;  size 32MB

	st	r1, @+r0

	ldi	r0, #-4              ;LDIMM	(r0, M32R_MCCR)

	ldi	r1, #0x703		; cache on (with invalidation)

	st	r1, @r0

arch/m32r/mm/cache.c

+21 −7
Original line number Diff line number Diff line 
/*

 *  linux/arch/m32r/mm/cache.c

 *

 *  Copyright (C) 2002  Hirokazu Takata

 *  Copyright (C) 2002-2005  Hirokazu Takata, Hayato Fujiwara

 */



#include <linux/config.h>
@@ -9,7 +9,8 @@ 


#undef MCCR



#if defined(CONFIG_CHIP_XNUX2) || defined(CONFIG_CHIP_M32700) || defined(CONFIG_CHIP_VDEC2) || defined(CONFIG_CHIP_OPSP)

#if defined(CONFIG_CHIP_XNUX2) || defined(CONFIG_CHIP_M32700) \

	|| defined(CONFIG_CHIP_VDEC2) || defined(CONFIG_CHIP_OPSP)

/* Cache Control Register */

#define MCCR		((volatile unsigned long*)0xfffffffc)

#define MCCR_CC		(1UL << 7)	/* Cache mode modify bit */
@@ -27,7 +28,7 @@ 
#define MCCR_IIV	(1UL << 0)	/* I-cache invalidate */

#define MCCR_ICACHE_INV		MCCR_IIV

#elif defined(CONFIG_CHIP_M32104)

#define MCCR		((volatile unsigned long*)0xfffffffc)

#define MCCR		((volatile unsigned short*)0xfffffffe)

#define MCCR_IIV	(1UL << 8)	/* I-cache invalidate */

#define MCCR_DIV	(1UL << 9)	/* D-cache invalidate */

#define MCCR_DCB	(1UL << 10)	/* D-cache copy back */
@@ -36,7 +37,7 @@ 
#define MCCR_ICACHE_INV		MCCR_IIV

#define MCCR_DCACHE_CB		MCCR_DCB

#define MCCR_DCACHE_CBINV	(MCCR_DIV|MCCR_DCB)

#endif /* CONFIG_CHIP_XNUX2 || CONFIG_CHIP_M32700 */

#endif



#ifndef MCCR

#error Unknown cache type.
@@ -47,29 +48,42 @@ 
void _flush_cache_all(void)

{

#if defined(CONFIG_CHIP_M32102)

	unsigned char mccr;

	*MCCR = MCCR_ICACHE_INV;

#elif defined(CONFIG_CHIP_M32104)

	unsigned short mccr;



	/* Copyback and invalidate D-cache */

	/* Invalidate I-cache */

	*MCCR |= (MCCR_ICACHE_INV | MCCR_DCACHE_CBINV);

#else

	unsigned long mccr;



	/* Copyback and invalidate D-cache */

	/* Invalidate I-cache */

	*MCCR = MCCR_ICACHE_INV | MCCR_DCACHE_CBINV;

	while ((mccr = *MCCR) & MCCR_IIV); /* loop while invalidating... */

#endif

	while ((mccr = *MCCR) & MCCR_IIV); /* loop while invalidating... */

}



/* Copy back D-cache and invalidate I-cache all */

void _flush_cache_copyback_all(void)

{

#if defined(CONFIG_CHIP_M32102)

	unsigned char mccr;

	*MCCR = MCCR_ICACHE_INV;

#elif defined(CONFIG_CHIP_M32104)

	unsigned short mccr;



	/* Copyback and invalidate D-cache */

	/* Invalidate I-cache */

	*MCCR |= (MCCR_ICACHE_INV | MCCR_DCACHE_CB);

#else

	unsigned long mccr;



	/* Copyback D-cache */

	/* Invalidate I-cache */

	*MCCR = MCCR_ICACHE_INV | MCCR_DCACHE_CB;

	while ((mccr = *MCCR) & MCCR_IIV); /* loop while invalidating... */



#endif

	while ((mccr = *MCCR) & MCCR_IIV); /* loop while invalidating... */

}