Commit 9c1bb37f authored by Christophe JAILLET's avatar Christophe JAILLET Committed by David S. Miller
Browse files

ptp: ocp: Fix a resource leak in an error handling path 



If an error occurs after a successful 'pci_ioremap_bar()' call, it must be
undone by a corresponding 'pci_iounmap()' call, as already done in the
remove function.

Fixes: a7e1abad ("ptp: Add clock driver for the OpenCompute TimeCard.")
Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Acked-by: default avatarRichard Cochran <richardcochran@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent e5cc361e

drivers/ptp/ptp_ocp.c

+3 −1
Original line number Diff line number Diff line
@@ -324,7 +324,7 @@ ptp_ocp_probe(struct pci_dev *pdev, const struct pci_device_id *id) 
	if (!bp->base) {

		dev_err(&pdev->dev, "io_remap bar0\n");

		err = -ENOMEM;

		goto out;

		goto out_release_regions;

	}

	bp->reg = bp->base + OCP_REGISTER_OFFSET;

	bp->tod = bp->base + TOD_REGISTER_OFFSET;
@@ -347,6 +347,8 @@ ptp_ocp_probe(struct pci_dev *pdev, const struct pci_device_id *id) 
	return 0;



out:

	pci_iounmap(pdev, bp->base);

out_release_regions:

	pci_release_regions(pdev);

out_disable:

	pci_disable_device(pdev);