Commit 9c3631d1 authored by Xinhao Liu's avatar Xinhao Liu Committed by Jason Gunthorpe
Browse files

RDMA/hns: Remove magic number 

Don't use unintelligible constants.

Link: https://lore.kernel.org/r/20211119140208.40416-10-liangwenpeng@huawei.com


Signed-off-by: default avatarXinhao Liu <liuxinhao5@hisilicon.com>
Signed-off-by: default avatarWenpeng Liang <liangwenpeng@huawei.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
parent 31835593

drivers/infiniband/hw/hns/hns_roce_hw_v2.c

+3 −1
Original line number Diff line number Diff line
@@ -677,6 +677,7 @@ static void hns_roce_write512(struct hns_roce_dev *hr_dev, u64 *val, 
static void write_dwqe(struct hns_roce_dev *hr_dev, struct hns_roce_qp *qp,

		       void *wqe)

{

#define HNS_ROCE_SL_SHIFT 2

	struct hns_roce_v2_rc_send_wqe *rc_sq_wqe = wqe;



	/* All kinds of DirectWQE have the same header field layout */
@@ -684,7 +685,8 @@ static void write_dwqe(struct hns_roce_dev *hr_dev, struct hns_roce_qp *qp, 
	roce_set_field(rc_sq_wqe->byte_4, V2_RC_SEND_WQE_BYTE_4_DB_SL_L_M,

		       V2_RC_SEND_WQE_BYTE_4_DB_SL_L_S, qp->sl);

	roce_set_field(rc_sq_wqe->byte_4, V2_RC_SEND_WQE_BYTE_4_DB_SL_H_M,

		       V2_RC_SEND_WQE_BYTE_4_DB_SL_H_S, qp->sl >> 2);

		       V2_RC_SEND_WQE_BYTE_4_DB_SL_H_S,

		       qp->sl >> HNS_ROCE_SL_SHIFT);

	roce_set_field(rc_sq_wqe->byte_4, V2_RC_SEND_WQE_BYTE_4_WQE_INDEX_M,

		       V2_RC_SEND_WQE_BYTE_4_WQE_INDEX_S, qp->sq.head);