Commit 9d16c385 authored by Lee Jones's avatar Lee Jones Committed by Kalle Valo
Browse files

brcmfmac: btcoex: Update 'brcmf_btcoex_state' and demote others 



The function headers are either very weakly documented or not at all.

Fixes the following W=1 kernel build warning(s):

 drivers/net/wireless/broadcom/brcm80211/brcmfmac/btcoex.c:94: warning: Function parameter or member 'reg50' not described in 'brcmf_btcoex_info'
 drivers/net/wireless/broadcom/brcm80211/brcmfmac/btcoex.c:94: warning: Function parameter or member 'saved_regs_part2' not described in 'brcmf_btcoex_info'
 drivers/net/wireless/broadcom/brcm80211/brcmfmac/btcoex.c:233: warning: Function parameter or member 'btci' not described in 'btcmf_btcoex_save_part1'
 drivers/net/wireless/broadcom/brcm80211/brcmfmac/btcoex.c:253: warning: Function parameter or member 'btci' not described in 'brcmf_btcoex_restore_part1'
 drivers/net/wireless/broadcom/brcm80211/brcmfmac/btcoex.c:273: warning: Function parameter or member 't' not described in 'brcmf_btcoex_timerfunc'
 drivers/net/wireless/broadcom/brcm80211/brcmfmac/btcoex.c:453: warning: Function parameter or member 'vif' not described in 'brcmf_btcoex_set_mode'
 drivers/net/wireless/broadcom/brcm80211/brcmfmac/btcoex.c:453: warning: Function parameter or member 'duration' not described in 'brcmf_btcoex_set_mode'
 drivers/net/wireless/broadcom/brcm80211/brcmfmac/btcoex.c:453: warning: Excess function parameter 'cfg' description in 'brcmf_btcoex_set_mode'

Cc: Arend van Spriel <arend.vanspriel@broadcom.com>
Cc: Franky Lin <franky.lin@broadcom.com>
Cc: Hante Meuleman <hante.meuleman@broadcom.com>
Cc: Chi-Hsien Lin <chi-hsien.lin@cypress.com>
Cc: Wright Feng <wright.feng@cypress.com>
Cc: Kalle Valo <kvalo@codeaurora.org>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: linux-wireless@vger.kernel.org
Cc: brcm80211-dev-list.pdl@broadcom.com
Cc: brcm80211-dev-list@cypress.com
Cc: netdev@vger.kernel.org
Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20200821071644.109970-17-lee.jones@linaro.org
parent 35b7fbfc

drivers/net/wireless/broadcom/brcm80211/brcmfmac/btcoex.c

+6 −6
Original line number Diff line number Diff line
@@ -65,11 +65,12 @@ enum brcmf_btcoex_state { 
 * @reg68: saved value of btc_params 68

 * @saved_regs_part1: flag indicating regs 66,41,68

 *	have been saved

 * @reg50: saved value of btc_params 50

 * @reg51: saved value of btc_params 51

 * @reg64: saved value of btc_params 64

 * @reg65: saved value of btc_params 65

 * @reg71: saved value of btc_params 71

 * @saved_regs_part1: flag indicating regs 50,51,64,65,71

 * @saved_regs_part2: flag indicating regs 50,51,64,65,71

 *	have been saved

 */

struct brcmf_btcoex_info {
@@ -226,7 +227,7 @@ static bool brcmf_btcoex_is_sco_active(struct brcmf_if *ifp) 
	return res;

}



/**

/*

 * btcmf_btcoex_save_part1() - save first step parameters.

 */

static void btcmf_btcoex_save_part1(struct brcmf_btcoex_info *btci)
@@ -246,7 +247,7 @@ static void btcmf_btcoex_save_part1(struct brcmf_btcoex_info *btci) 
	}

}



/**

/*

 * brcmf_btcoex_restore_part1() - restore first step parameters.

 */

static void brcmf_btcoex_restore_part1(struct brcmf_btcoex_info *btci)
@@ -266,7 +267,7 @@ static void brcmf_btcoex_restore_part1(struct brcmf_btcoex_info *btci) 
	}

}



/**

/*

 * brcmf_btcoex_timerfunc() - BT coex timer callback

 */

static void brcmf_btcoex_timerfunc(struct timer_list *t)
@@ -441,9 +442,8 @@ static void brcmf_btcoex_dhcp_end(struct brcmf_btcoex_info *btci) 
	}

}



/**

/*

 * brcmf_btcoex_set_mode - set BT coex mode

 * @cfg: driver private cfg80211 data

 * @mode: Wifi-Bluetooth coexistence mode

 *

 * return: 0 on success