Commit 9d6b0cd7 authored by Matthew Wilcox (Oracle)'s avatar Matthew Wilcox (Oracle)
Browse files

fs: Remove flags parameter from aops->write_begin 



There are no more aop flags left, so remove the parameter.

Signed-off-by: default avatarMatthew Wilcox (Oracle) <willy@infradead.org>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
parent 8371f30c

Documentation/filesystems/locking.rst

+1 −1
Original line number Diff line number Diff line
@@ -242,7 +242,7 @@ prototypes:: 
	bool (*dirty_folio)(struct address_space *, struct folio *folio);

	void (*readahead)(struct readahead_control *);

	int (*write_begin)(struct file *, struct address_space *mapping,

				loff_t pos, unsigned len, unsigned flags,

				loff_t pos, unsigned len,

				struct page **pagep, void **fsdata);

	int (*write_end)(struct file *, struct address_space *mapping,

				loff_t pos, unsigned len, unsigned copied,

Documentation/filesystems/vfs.rst

+1 −4
Original line number Diff line number Diff line
@@ -727,7 +727,7 @@ cache in your filesystem. The following members are defined: 
		bool (*dirty_folio)(struct address_space *, struct folio *);

		void (*readahead)(struct readahead_control *);

		int (*write_begin)(struct file *, struct address_space *mapping,

				   loff_t pos, unsigned len, unsigned flags,

				   loff_t pos, unsigned len,

				struct page **pagep, void **fsdata);

		int (*write_end)(struct file *, struct address_space *mapping,

				 loff_t pos, unsigned len, unsigned copied,
@@ -832,9 +832,6 @@ cache in your filesystem. The following members are defined: 
	passed to write_begin is greater than the number of bytes copied

	into the page).



	flags is a field for AOP_FLAG_xxx flags, described in

	include/linux/fs.h.



	A void * may be returned in fsdata, which then gets passed into

	write_end.

block/fops.c

+1 −2
Original line number Diff line number Diff line
@@ -398,8 +398,7 @@ static void blkdev_readahead(struct readahead_control *rac) 
}



static int blkdev_write_begin(struct file *file, struct address_space *mapping,

		loff_t pos, unsigned len, unsigned flags, struct page **pagep,

		void **fsdata)

		loff_t pos, unsigned len, struct page **pagep, void **fsdata)

{

	return block_write_begin(mapping, pos, len, pagep, blkdev_get_block);

}

fs/9p/vfs_addr.c

+1 −1
Original line number Diff line number Diff line
@@ -260,7 +260,7 @@ v9fs_direct_IO(struct kiocb *iocb, struct iov_iter *iter) 
}



static int v9fs_write_begin(struct file *filp, struct address_space *mapping,

			    loff_t pos, unsigned int len, unsigned int flags,

			    loff_t pos, unsigned int len,

			    struct page **subpagep, void **fsdata)

{

	int retval;

fs/adfs/inode.c

+1 −1
Original line number Diff line number Diff line
@@ -52,7 +52,7 @@ static void adfs_write_failed(struct address_space *mapping, loff_t to) 
}



static int adfs_write_begin(struct file *file, struct address_space *mapping,

			loff_t pos, unsigned len, unsigned flags,

			loff_t pos, unsigned len,

			struct page **pagep, void **fsdata)

{

	int ret;