Commit 9d7fef7c authored by Koby Elbaz's avatar Koby Elbaz Committed by Oded Gabbay
Browse files

accel/habanalabs: change COMMS warning messages to error level 



COMMS protocol is used for LKD <--> FW communication, and any
communication failure between the two might turn out to be
destructive, hence, it should be well emphasized.

Signed-off-by: default avatarKoby Elbaz <kelbaz@habana.ai>
Reviewed-by: default avatarOded Gabbay <ogabbay@kernel.org>
Signed-off-by: default avatarOded Gabbay <ogabbay@kernel.org>
Reviewed-by: default avatarStanislaw Gruszka <stanislaw.gruszka@linux.intel.com>
parent fb10da93

drivers/accel/habanalabs/common/firmware_if.c

+2 −2
Original line number Diff line number Diff line
@@ -1263,7 +1263,7 @@ void hl_fw_ask_hard_reset_without_linux(struct hl_device *hdev) 
				COMMS_RST_DEV, 0, false,

				hdev->fw_loader.cpu_timeout);

		if (rc)

			dev_warn(hdev->dev, "Failed sending COMMS_RST_DEV\n");

			dev_err(hdev->dev, "Failed sending COMMS_RST_DEV\n");

	} else {

		WREG32(static_loader->kmd_msg_to_cpu_reg, KMD_MSG_RST_DEV);

	}
@@ -1284,7 +1284,7 @@ void hl_fw_ask_halt_machine_without_linux(struct hl_device *hdev) 
				COMMS_GOTO_WFE, 0, true,

				hdev->fw_loader.cpu_timeout);

		if (rc)

			dev_warn(hdev->dev, "Failed sending COMMS_GOTO_WFE\n");

			dev_err(hdev->dev, "Failed sending COMMS_GOTO_WFE\n");

	} else {

		WREG32(static_loader->kmd_msg_to_cpu_reg, KMD_MSG_GOTO_WFE);

		msleep(static_loader->cpu_reset_wait_msec);