Commit a0b9beca authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Lee Jones
Browse files

mfd: core: Remove .enable() and .disable() callbacks 



With commit dd77f5fa97d3 ("mfd: Remove toshiba tmio drivers") the last
mfd driver that implements these callbacks is gone and since commit
652719b1 ("w1: remove ds1wm driver") the last user is gone. The
corresponding functions mfd_cell_enable() and mfd_cell_disable() are
also unused (since commit 0ca222c8 ("leds: Remove asic3 driver")).

Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: default avatarArnd Bergmann <arnd@arndb.de>
Signed-off-by: default avatarLee Jones <lee@kernel.org>
Link: https://lore.kernel.org/r/20230308091257.2404932-1-u.kleine-koenig@pengutronix.de
parent e8e9837d

drivers/mfd/mfd-core.c

+0 −26
Original line number Diff line number Diff line
@@ -33,32 +33,6 @@ static struct device_type mfd_dev_type = { 
	.name	= "mfd_device",

};



int mfd_cell_enable(struct platform_device *pdev)

{

	const struct mfd_cell *cell = mfd_get_cell(pdev);



	if (!cell->enable) {

		dev_dbg(&pdev->dev, "No .enable() call-back registered\n");

		return 0;

	}



	return cell->enable(pdev);

}

EXPORT_SYMBOL(mfd_cell_enable);



int mfd_cell_disable(struct platform_device *pdev)

{

	const struct mfd_cell *cell = mfd_get_cell(pdev);



	if (!cell->disable) {

		dev_dbg(&pdev->dev, "No .disable() call-back registered\n");

		return 0;

	}



	return cell->disable(pdev);

}

EXPORT_SYMBOL(mfd_cell_disable);



#if IS_ENABLED(CONFIG_ACPI)

struct match_ids_walk_data {

	struct acpi_device_id *ids;

include/linux/mfd/core.h

+0 −12
Original line number Diff line number Diff line
@@ -68,9 +68,6 @@ struct mfd_cell { 
	int			id;

	int			level;



	int			(*enable)(struct platform_device *dev);

	int			(*disable)(struct platform_device *dev);



	int			(*suspend)(struct platform_device *dev);

	int			(*resume)(struct platform_device *dev);
@@ -123,15 +120,6 @@ struct mfd_cell { 
	const char * const	*parent_supplies;

};



/*

 * Convenience functions for clients using shared cells.  Refcounting

 * happens automatically, with the cell's enable/disable callbacks

 * being called only when a device is first being enabled or no other

 * clients are making use of it.

 */

extern int mfd_cell_enable(struct platform_device *pdev);

extern int mfd_cell_disable(struct platform_device *pdev);



/*

 * Given a platform device that's been created by mfd_add_devices(), fetch

 * the mfd_cell that created it.