Unverified Commit a140785b authored by Pierre-Louis Bossart's avatar Pierre-Louis Bossart Committed by Mark Brown
Browse files

ASoC: Intel: atom: sst_ipc: remove useless initializations 



cppcheck throws invalid NULL dereference warnings but there's indeed
no need to initialize a loop variable or initialize to NULL before
allocating memory.

Signed-off-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: default avatarBard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: default avatarPéter Ujfalusi <peter.ujfalusi@linux.intel.com>
Link: https://lore.kernel.org/r/20220520211719.607543-8-pierre-louis.bossart@linux.intel.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent d8af5411

sound/soc/intel/atom/sst/sst_ipc.c

+3 −3
Original line number Diff line number Diff line
@@ -28,7 +28,7 @@ 
struct sst_block *sst_create_block(struct intel_sst_drv *ctx,

					u32 msg_id, u32 drv_id)

{

	struct sst_block *msg = NULL;

	struct sst_block *msg;



	dev_dbg(ctx->dev, "Enter\n");

	msg = kzalloc(sizeof(*msg), GFP_KERNEL);
@@ -63,7 +63,7 @@ struct sst_block *sst_create_block(struct intel_sst_drv *ctx, 
int sst_wake_up_block(struct intel_sst_drv *ctx, int result,

		u32 drv_id, u32 ipc, void *data, u32 size)

{

	struct sst_block *block = NULL;

	struct sst_block *block;



	dev_dbg(ctx->dev, "Enter\n");
@@ -91,7 +91,7 @@ int sst_wake_up_block(struct intel_sst_drv *ctx, int result, 


int sst_free_block(struct intel_sst_drv *ctx, struct sst_block *freed)

{

	struct sst_block *block = NULL, *__block;

	struct sst_block *block, *__block;



	dev_dbg(ctx->dev, "Enter\n");

	spin_lock_bh(&ctx->block_lock);