Commit a1bb5cca authored by Daniel W. S. Almeida's avatar Daniel W. S. Almeida Committed by Mauro Carvalho Chehab
Browse files

media: pci: saa7164-dvb.c: replace if(cond) BUG() with BUG_ON() 

Fix the following coccinelle reports:

drivers/media/pci/saa7164/saa7164-dvb.c:341:2-5:
WARNING: Use BUG_ON instead of if condition followed by BUG

drivers/media/pci/saa7164/saa7164-dvb.c:483:2-5:
WARNING: Use BUG_ON instead of if condition followed by BUG.

Found using - Coccinelle (http://coccinelle.lip6.fr

)

Signed-off-by: default avatarDaniel W. S. Almeida <dwlsalmeida@gmail.com>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
parent 2ad5e2e4

drivers/media/pci/saa7164/saa7164-dvb.c

+2 −5
Original line number Diff line number Diff line
@@ -337,8 +337,7 @@ static int dvb_register(struct saa7164_port *port) 


	dprintk(DBGLVL_DVB, "%s(port=%d)\n", __func__, port->nr);



	if (port->type != SAA7164_MPEG_DVB)

		BUG();

	BUG_ON(port->type != SAA7164_MPEG_DVB);



	/* Sanity check that the PCI configuration space is active */

	if (port->hwcfg.BARLocation == 0) {
@@ -479,8 +478,7 @@ int saa7164_dvb_unregister(struct saa7164_port *port) 


	dprintk(DBGLVL_DVB, "%s()\n", __func__);



	if (port->type != SAA7164_MPEG_DVB)

		BUG();

	BUG_ON(port->type != SAA7164_MPEG_DVB);



	/* Remove any allocated buffers */

	mutex_lock(&port->dmaqueue_lock);
@@ -740,4 +738,3 @@ int saa7164_dvb_register(struct saa7164_port *port) 
	printk(KERN_ERR "%s() Frontend/I2C initialization failed\n", __func__);

	return -1;

}