Commit a3a7482a authored by Lukas Bulwahn's avatar Lukas Bulwahn Committed by Linus Walleij
Browse files

pinctrl: mxs: avoid defines prefixed with CONFIG 



Defines prefixed with "CONFIG" should be limited to proper Kconfig options,
that are introduced in a Kconfig file.

Here, expressions to convert pin configurations to booleans for pull-up,
voltage and mA are macro definitions that begin with "CONFIG".

To avoid defines prefixed with "CONFIG", rename these defines to begin with
"PIN_CONFIG" instead.

No functional change.

Signed-off-by: default avatarLukas Bulwahn <lukas.bulwahn@gmail.com>
Link: https://lore.kernel.org/r/20221215092128.3954-1-lukas.bulwahn@gmail.com


Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent f3cd465b

drivers/pinctrl/freescale/pinctrl-mxs.c

+3 −3
Original line number Diff line number Diff line
@@ -269,9 +269,9 @@ static int mxs_pinconf_group_set(struct pinctrl_dev *pctldev, 
	for (n = 0; n < num_configs; n++) {

		config = configs[n];



		ma = CONFIG_TO_MA(config);

		vol = CONFIG_TO_VOL(config);

		pull = CONFIG_TO_PULL(config);

		ma = PIN_CONFIG_TO_MA(config);

		vol = PIN_CONFIG_TO_VOL(config);

		pull = PIN_CONFIG_TO_PULL(config);



		for (i = 0; i < g->npins; i++) {

			bank = PINID_TO_BANK(g->pins[i]);

drivers/pinctrl/freescale/pinctrl-mxs.h

+3 −3
Original line number Diff line number Diff line
@@ -44,9 +44,9 @@ 
#define VOL_SHIFT		3

#define MA_PRESENT		(1 << 2)

#define MA_SHIFT		0

#define CONFIG_TO_PULL(c)	((c) >> PULL_SHIFT & 0x1)

#define CONFIG_TO_VOL(c)	((c) >> VOL_SHIFT & 0x1)

#define CONFIG_TO_MA(c)		((c) >> MA_SHIFT & 0x3)

#define PIN_CONFIG_TO_PULL(c)	((c) >> PULL_SHIFT & 0x1)

#define PIN_CONFIG_TO_VOL(c)	((c) >> VOL_SHIFT & 0x1)

#define PIN_CONFIG_TO_MA(c)	((c) >> MA_SHIFT & 0x3)



struct mxs_function {

	const char *name;