Commit a4338ed2 authored by Oscar Carter's avatar Oscar Carter Committed by Greg Kroah-Hartman
Browse files

staging: wilc1000: Increase the size of wid_list array 



Increase by one the size of wid_list array as index variable can reach a
value of 5. If this happens, an out-of-bounds access is performed.

Also, use a #define instead of a hard-coded literal for the new array
size.

Addresses-Coverity-ID: 1451981 ("Out-of-bounds access")
Fixes: f5a3cb90 ("staging: wilc1000: add passive scan support")
Acked-by: default avatarAjay Singh <ajay.kathat@microchip.com>
Signed-off-by: default avatarOscar Carter <oscar.carter@gmx.com>
Link: https://lore.kernel.org/r/20200504150911.4470-1-oscar.carter@gmx.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 8d8a1424

drivers/staging/wilc1000/hif.c

+3 −1
Original line number Diff line number Diff line
@@ -11,6 +11,8 @@ 


#define WILC_FALSE_FRMWR_CHANNEL		100



#define WILC_SCAN_WID_LIST_SIZE		6



struct wilc_rcvd_mac_info {

	u8 status;

};
@@ -151,7 +153,7 @@ int wilc_scan(struct wilc_vif *vif, u8 scan_source, u8 scan_type, 
	      void *user_arg, struct cfg80211_scan_request *request)

{

	int result = 0;

	struct wid wid_list[5];

	struct wid wid_list[WILC_SCAN_WID_LIST_SIZE];

	u32 index = 0;

	u32 i, scan_timeout;

	u8 *buffer;