Commit a4eef305 authored by Lars-Peter Clausen's avatar Lars-Peter Clausen Committed by Jonathan Cameron
Browse files

staging:iio:adt7310: Do not return error code in interrupt handler



The interrupt handler should only ever return one of the three irqreturn_t
constants and not an error code. Also make sure to always call
iio_trigger_notify_done before leaving the trigger handler.

Signed-off-by: default avatarLars-Peter Clausen <lars@metafoo.de>
Signed-off-by: default avatarJonathan Cameron <jic23@kernel.org>
parent abad65cb
Loading
Loading
Loading
Loading
+3 −1
Original line number Diff line number Diff line
@@ -397,7 +397,7 @@ static irqreturn_t adt7310_event_handler(int irq, void *private)

	ret = adt7310_spi_read_byte(chip, ADT7310_STATUS, &status);
	if (ret)
		return ret;
		goto done;

	if (status & ADT7310_STAT_T_HIGH)
		iio_push_event(indio_dev,
@@ -417,6 +417,8 @@ static irqreturn_t adt7310_event_handler(int irq, void *private)
						    IIO_EV_TYPE_THRESH,
						    IIO_EV_DIR_RISING),
			timestamp);

done:
	return IRQ_HANDLED;
}