Commit a52a5451 authored by Maíra Canal's avatar Maíra Canal Committed by Shuah Khan
Browse files

kunit: Use KUNIT_EXPECT_MEMEQ macro 



Use KUNIT_EXPECT_MEMEQ to compare memory blocks in replacement of the
KUNIT_EXPECT_EQ macro. Therefor, the statement

    KUNIT_EXPECT_EQ(test, memcmp(foo, bar, size), 0);

is replaced by:

    KUNIT_EXPECT_MEMEQ(test, foo, bar, size);

Signed-off-by: default avatarMaíra Canal <mairacanal@riseup.net>
Acked-by: default avatarDaniel Latypov <dlatypov@google.com>
Reviewed-by: default avatarDavid Gow <davidgow@google.com>
Signed-off-by: default avatarShuah Khan <skhan@linuxfoundation.org>
parent 3b30fb62

drivers/gpu/drm/tests/drm_format_helper_test.c

+6 −6
Original line number Diff line number Diff line
@@ -315,7 +315,7 @@ static void drm_test_fb_xrgb8888_to_gray8(struct kunit *test) 
	iosys_map_set_vaddr(&src, xrgb8888);



	drm_fb_xrgb8888_to_gray8(&dst, &result->dst_pitch, &src, &fb, &params->clip);

	KUNIT_EXPECT_EQ(test, memcmp(buf, result->expected, dst_size), 0);

	KUNIT_EXPECT_MEMEQ(test, buf, result->expected, dst_size);

}



static void drm_test_fb_xrgb8888_to_rgb332(struct kunit *test)
@@ -345,7 +345,7 @@ static void drm_test_fb_xrgb8888_to_rgb332(struct kunit *test) 
	iosys_map_set_vaddr(&src, xrgb8888);



	drm_fb_xrgb8888_to_rgb332(&dst, &result->dst_pitch, &src, &fb, &params->clip);

	KUNIT_EXPECT_EQ(test, memcmp(buf, result->expected, dst_size), 0);

	KUNIT_EXPECT_MEMEQ(test, buf, result->expected, dst_size);

}



static void drm_test_fb_xrgb8888_to_rgb565(struct kunit *test)
@@ -375,10 +375,10 @@ static void drm_test_fb_xrgb8888_to_rgb565(struct kunit *test) 
	iosys_map_set_vaddr(&src, xrgb8888);



	drm_fb_xrgb8888_to_rgb565(&dst, &result->dst_pitch, &src, &fb, &params->clip, false);

	KUNIT_EXPECT_EQ(test, memcmp(buf, result->expected, dst_size), 0);

	KUNIT_EXPECT_MEMEQ(test, buf, result->expected, dst_size);



	drm_fb_xrgb8888_to_rgb565(&dst, &result->dst_pitch, &src, &fb, &params->clip, true);

	KUNIT_EXPECT_EQ(test, memcmp(buf, result->expected_swab, dst_size), 0);

	KUNIT_EXPECT_MEMEQ(test, buf, result->expected_swab, dst_size);

}



static void drm_test_fb_xrgb8888_to_rgb888(struct kunit *test)
@@ -408,7 +408,7 @@ static void drm_test_fb_xrgb8888_to_rgb888(struct kunit *test) 
	iosys_map_set_vaddr(&src, xrgb8888);



	drm_fb_xrgb8888_to_rgb888(&dst, &result->dst_pitch, &src, &fb, &params->clip);

	KUNIT_EXPECT_EQ(test, memcmp(buf, result->expected, dst_size), 0);

	KUNIT_EXPECT_MEMEQ(test, buf, result->expected, dst_size);

}



static void drm_test_fb_xrgb8888_to_xrgb2101010(struct kunit *test)
@@ -439,7 +439,7 @@ static void drm_test_fb_xrgb8888_to_xrgb2101010(struct kunit *test) 


	drm_fb_xrgb8888_to_xrgb2101010(&dst, &result->dst_pitch, &src, &fb, &params->clip);

	buf = le32buf_to_cpu(test, buf, dst_size / sizeof(u32));

	KUNIT_EXPECT_EQ(test, memcmp(buf, result->expected, dst_size), 0);

	KUNIT_EXPECT_MEMEQ(test, buf, result->expected, dst_size);

}



static struct kunit_case drm_format_helper_test_cases[] = {

net/core/dev_addr_lists_test.c

+2 −2
Original line number Diff line number Diff line
@@ -71,11 +71,11 @@ static void dev_addr_test_basic(struct kunit *test) 


	memset(addr, 2, sizeof(addr));

	eth_hw_addr_set(netdev, addr);

	KUNIT_EXPECT_EQ(test, 0, memcmp(netdev->dev_addr, addr, sizeof(addr)));

	KUNIT_EXPECT_MEMEQ(test, netdev->dev_addr, addr, sizeof(addr));



	memset(addr, 3, sizeof(addr));

	dev_addr_set(netdev, addr);

	KUNIT_EXPECT_EQ(test, 0, memcmp(netdev->dev_addr, addr, sizeof(addr)));

	KUNIT_EXPECT_MEMEQ(test, netdev->dev_addr, addr, sizeof(addr));

}



static void dev_addr_test_sync_one(struct kunit *test)