Commit a54af1b7 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Johan Hovold
Browse files

USB: serial: drop if with an always false condition 



In a bus remove function the passed device is always valid, so there is
no need to check for it being NULL.

(Side note: The check for port being non-NULL is broken anyhow, because
to_usb_serial_port() is a wrapper around container_of() for a member that is
not the first one. So port can hardly become NULL.)

Signed-off-by: default avatarUwe Kleine-König <uwe@kleine-koenig.org>
Link: https://lore.kernel.org/r/20210208143149.963644-1-uwe@kleine-koenig.org


Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
parent 6420a569

drivers/usb/serial/bus.c

+1 −5
Original line number Diff line number Diff line
@@ -86,16 +86,12 @@ static int usb_serial_device_probe(struct device *dev) 


static int usb_serial_device_remove(struct device *dev)

{

	struct usb_serial_port *port = to_usb_serial_port(dev);

	struct usb_serial_driver *driver;

	struct usb_serial_port *port;

	int retval = 0;

	int minor;

	int autopm_err;



	port = to_usb_serial_port(dev);

	if (!port)

		return -ENODEV;



	/*

	 * Make sure suspend/resume doesn't race against port_remove.

	 *