Commit a6b1e709 authored by Zhen Lei's avatar Zhen Lei Committed by Mauro Carvalho Chehab
Browse files

media: tc358743: Fix error return code in tc358743_probe_of() 



When the CSI bps per lane is not in the valid range, an appropriate error
code -EINVAL should be returned. However, we currently do not explicitly
assign this error code to 'ret'. As a result, 0 was incorrectly returned.

Fixes: 25614824 ("[media] tc358743: support probe from device tree")
Reported-by: default avatarHulk Robot <hulkci@huawei.com>
Signed-off-by: default avatarZhen Lei <thunder.leizhen@huawei.com>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
parent d67fa04c

drivers/media/i2c/tc358743.c

+1 −0
Original line number Diff line number Diff line
@@ -1974,6 +1974,7 @@ static int tc358743_probe_of(struct tc358743_state *state) 
	bps_pr_lane = 2 * endpoint.link_frequencies[0];

	if (bps_pr_lane < 62500000U || bps_pr_lane > 1000000000U) {

		dev_err(dev, "unsupported bps per lane: %u bps\n", bps_pr_lane);

		ret = -EINVAL;

		goto disable_clk;

	}