Commit a707df30 authored by Tom Rix's avatar Tom Rix Committed by Peter Zijlstra
Browse files

sched/fair: Rename variable cpu_util eff_util 



cppcheck reports
kernel/sched/fair.c:7436:17: style: Local variable 'cpu_util' shadows outer function [shadowFunction]
  unsigned long cpu_util;
                ^

Clean this up by renaming the variable to eff_util

Signed-off-by: default avatarTom Rix <trix@redhat.com>
Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: default avatarValentin Schneider <vschneid@redhat.com>
Reviewed-by: default avatarDietmar Eggemann <dietmar.eggemann@arm.com>
Link: https://lore.kernel.org/r/20230611122535.183654-1-trix@redhat.com
parent 5416bf1c

kernel/sched/fair.c

+3 −3
Original line number Diff line number Diff line
@@ -7433,7 +7433,7 @@ eenv_pd_max_util(struct energy_env *eenv, struct cpumask *pd_cpus, 
	for_each_cpu(cpu, pd_cpus) {

		struct task_struct *tsk = (cpu == dst_cpu) ? p : NULL;

		unsigned long util = cpu_util(cpu, p, dst_cpu, 1);

		unsigned long cpu_util;

		unsigned long eff_util;



		/*

		 * Performance domain frequency: utilization clamping
@@ -7442,8 +7442,8 @@ eenv_pd_max_util(struct energy_env *eenv, struct cpumask *pd_cpus, 
		 * NOTE: in case RT tasks are running, by default the

		 * FREQUENCY_UTIL's utilization can be max OPP.

		 */

		cpu_util = effective_cpu_util(cpu, util, FREQUENCY_UTIL, tsk);

		max_util = max(max_util, cpu_util);

		eff_util = effective_cpu_util(cpu, util, FREQUENCY_UTIL, tsk);

		max_util = max(max_util, eff_util);

	}



	return min(max_util, eenv->cpu_cap);