Commit a7620924 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Jonathan Cameron
Browse files

iio:chemical:atlas: Improve error reporting for problems during .remove() 



Returning an error value in an i2c remove callback results in a generic
error message being emitted by the i2c core, but otherwise it doesn't
make a difference. The device goes away anyhow and the devm cleanups are
called.

So instead of triggering the generic i2c error message, emit a more
helpful message if a problem occurs and return 0 to suppress the generic
message.

This patch is a preparation for making i2c remove callbacks return void.

Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20220515155929.338656-4-u.kleine-koenig@pengutronix.de


Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
parent 8f760ce7

drivers/iio/chemical/atlas-sensor.c

+7 −1
Original line number Diff line number Diff line
@@ -726,6 +726,7 @@ static int atlas_remove(struct i2c_client *client) 
{

	struct iio_dev *indio_dev = i2c_get_clientdata(client);

	struct atlas_data *data = iio_priv(indio_dev);

	int ret;



	iio_device_unregister(indio_dev);

	iio_triggered_buffer_cleanup(indio_dev);
@@ -734,7 +735,12 @@ static int atlas_remove(struct i2c_client *client) 
	pm_runtime_disable(&client->dev);

	pm_runtime_set_suspended(&client->dev);



	return atlas_set_powermode(data, 0);

	ret = atlas_set_powermode(data, 0);

	if (ret)

		dev_err(&client->dev, "Failed to power down device (%pe)\n",

			ERR_PTR(ret));



	return 0;

}



static int atlas_runtime_suspend(struct device *dev)