Commit a84b17e2 authored by Peter Senna Tschudin's avatar Peter Senna Tschudin Committed by Mauro Carvalho Chehab
Browse files

[media] drivers/media/rc/ati_remote.c: fix error return code

Convert a nonnegative error return code to a negative one, as returned
elsewhere in the function.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/

)
// <smpl>
(
if@p1 (\(ret < 0\|ret != 0\))
 { ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
    when != &ret
*if(...)
{
  ... when != ret = e2
      when forall
 return ret;
}
// </smpl>

Signed-off-by: default avatarPeter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent 6ea7cf76
Loading
Loading
Loading
Loading
+3 −1
Original line number Diff line number Diff line
@@ -937,8 +937,10 @@ static int ati_remote_probe(struct usb_interface *interface,
	/* Set up and register mouse input device */
	if (mouse) {
		input_dev = input_allocate_device();
		if (!input_dev)
		if (!input_dev) {
			err = -ENOMEM;
			goto fail4;
		}

		ati_remote->idev = input_dev;
		ati_remote_input_init(ati_remote);