Commit a8b032b5 authored by Bart Van Assche's avatar Bart Van Assche Committed by Martin K. Petersen
Browse files

scsi: ufs: Move the ufs_is_valid_unit_desc_lun() definition 

Move the definition of this function from a public into a private header
file since it is only used inside the UFS core.

Link: https://lore.kernel.org/r/20220419225811.4127248-29-bvanassche@acm.org


Tested-by: default avatarBean Huo <beanhuo@micron.com>
Reviewed-by: default avatarBean Huo <beanhuo@micron.com>
Signed-off-by: default avatarBart Van Assche <bvanassche@acm.org>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 743b09d8

drivers/scsi/ufs/ufs.h

+0 −19
Original line number Diff line number Diff line
@@ -620,23 +620,4 @@ enum ufs_trace_tsf_t { 
	UFS_TSF_CDB, UFS_TSF_OSF, UFS_TSF_TM_INPUT, UFS_TSF_TM_OUTPUT

};



/**

 * ufs_is_valid_unit_desc_lun - checks if the given LUN has a unit descriptor

 * @dev_info: pointer of instance of struct ufs_dev_info

 * @lun: LU number to check

 * @return: true if the lun has a matching unit descriptor, false otherwise

 */

static inline bool ufs_is_valid_unit_desc_lun(struct ufs_dev_info *dev_info,

		u8 lun, u8 param_offset)

{

	if (!dev_info || !dev_info->max_lu_supported) {

		pr_err("Max General LU supported by UFS isn't initialized\n");

		return false;

	}

	/* WB is available only for the logical unit from 0 to 7 */

	if (param_offset == UNIT_DESC_PARAM_WB_BUF_ALLOC_UNITS)

		return lun < UFS_UPIU_MAX_WB_LUN_ID;

	return lun == UFS_UPIU_RPMB_WLUN || (lun < dev_info->max_lu_supported);

}



#endif /* End of Header */

drivers/scsi/ufs/ufshcd-priv.h

+19 −0
Original line number Diff line number Diff line
@@ -276,4 +276,23 @@ static inline int ufshcd_rpm_put(struct ufs_hba *hba) 
	return pm_runtime_put(&hba->ufs_device_wlun->sdev_gendev);

}



/**

 * ufs_is_valid_unit_desc_lun - checks if the given LUN has a unit descriptor

 * @dev_info: pointer of instance of struct ufs_dev_info

 * @lun: LU number to check

 * @return: true if the lun has a matching unit descriptor, false otherwise

 */

static inline bool ufs_is_valid_unit_desc_lun(struct ufs_dev_info *dev_info,

		u8 lun, u8 param_offset)

{

	if (!dev_info || !dev_info->max_lu_supported) {

		pr_err("Max General LU supported by UFS isn't initialized\n");

		return false;

	}

	/* WB is available only for the logical unit from 0 to 7 */

	if (param_offset == UNIT_DESC_PARAM_WB_BUF_ALLOC_UNITS)

		return lun < UFS_UPIU_MAX_WB_LUN_ID;

	return lun == UFS_UPIU_RPMB_WLUN || (lun < dev_info->max_lu_supported);

}



#endif /* _UFSHCD_PRIV_H_ */