Commit a90b6543 authored by Cristian Marussi's avatar Cristian Marussi Committed by Sudeep Holla
Browse files

firmware: arm_scmi: Fix call site of scmi_notification_exit 

Call scmi_notification_exit() only when SCMI platform driver instance has
been really successfully removed.

Link: https://lore.kernel.org/r/20210112191326.29091-1-cristian.marussi@arm.com


Fixes: 6b8a6913 ("firmware: arm_scmi: Enable notification core")
Signed-off-by: default avatarCristian Marussi <cristian.marussi@arm.com>
[sudeep.holla: Move the call outside the list mutex locking]
Signed-off-by: default avatarSudeep Holla <sudeep.holla@arm.com>
parent 6054d97a

drivers/firmware/arm_scmi/driver.c

+2 −2
Original line number Diff line number Diff line
@@ -848,8 +848,6 @@ static int scmi_remove(struct platform_device *pdev) 
	struct scmi_info *info = platform_get_drvdata(pdev);

	struct idr *idr = &info->tx_idr;



	scmi_notification_exit(&info->handle);



	mutex_lock(&scmi_list_mutex);

	if (info->users)

		ret = -EBUSY;
@@ -860,6 +858,8 @@ static int scmi_remove(struct platform_device *pdev) 
	if (ret)

		return ret;



	scmi_notification_exit(&info->handle);



	/* Safe to free channels since no more users */

	ret = idr_for_each(idr, info->desc->ops->chan_free, idr);

	idr_destroy(&info->tx_idr);