Commit a9c6a1fc authored by Rob Herring's avatar Rob Herring Committed by Jernej Skrabec
Browse files

soc: sunxi: Use of_property_present() for testing DT property presence 



It is preferred to use typed property access functions (i.e.
of_property_read_<type> functions) rather than low-level
of_get_property/of_find_property functions for reading properties. As
part of this, convert of_get_property/of_find_property calls to the
recently added of_property_present() helper when we just want to test
for presence of a property and nothing more.

Signed-off-by: default avatarRob Herring <robh@kernel.org>
Reviewed-by: default avatarJernej Skrabec <jernej.skrabec@gmail.com>
Reviewed-by: default avatarAndre Przywara <andre.przywara@arm.com>
Link: https://lore.kernel.org/r/20230310144724.1545223-1-robh@kernel.org


Signed-off-by: default avatarJernej Skrabec <jernej.skrabec@gmail.com>
parent fe15c26e

drivers/soc/sunxi/sunxi_mbus.c

+1 −1
Original line number Diff line number Diff line
@@ -82,7 +82,7 @@ static int sunxi_mbus_notifier(struct notifier_block *nb, 
	 * Older DTs or SoCs who are not clearly understood need to set

	 * that DMA offset though.

	 */

	if (of_find_property(dev->of_node, "interconnects", NULL))

	if (of_property_present(dev->of_node, "interconnects"))

		return NOTIFY_DONE;



	ret = dma_direct_set_offset(dev, PHYS_OFFSET, 0, SZ_4G);