Commit a9c73937 authored by David Kershner's avatar David Kershner Committed by Greg Kroah-Hartman
Browse files

staging: unisys: visorbus: move parahotplug_process_list 



The function parahotplug_process_list needs to be moved lower in the file
to avoid extraneous function prototypes.

Reported-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarDavid Kershner <david.kershner@unisys.com>
Reviewed-by: default avatarTim Sell <Timothy.Sell@unisys.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 8a285327

drivers/staging/unisys/visorbus/visorchipset.c

+31 −32
Original line number Diff line number Diff line
@@ -179,7 +179,6 @@ struct parahotplug_request { 


static LIST_HEAD(parahotplug_request_list);

static DEFINE_SPINLOCK(parahotplug_request_list_lock);	/* lock for above */

static void parahotplug_process_list(void);



/* info for /dev/visorchipset */

static dev_t major_dev = -1; /*< indicates major num for device */
@@ -1465,37 +1464,6 @@ parahotplug_request_kickoff(struct parahotplug_request *req) 
			   envp);

}



/**

 * parahotplug_process_list() - remove any request from the list that's been on

 *                              there too long and respond with an error

 */

static void

parahotplug_process_list(void)

{

	struct list_head *pos;

	struct list_head *tmp;



	spin_lock(&parahotplug_request_list_lock);



	list_for_each_safe(pos, tmp, &parahotplug_request_list) {

		struct parahotplug_request *req =

		    list_entry(pos, struct parahotplug_request, list);



		if (!time_after_eq(jiffies, req->expiration))

			continue;



		list_del(pos);

		if (req->msg.hdr.flags.response_expected)

			controlvm_respond_physdev_changestate(

				&req->msg.hdr,

				CONTROLVM_RESP_ERROR_DEVICE_UDEV_TIMEOUT,

				req->msg.cmd.device_change_state.state);

		parahotplug_request_destroy(req);

	}



	spin_unlock(&parahotplug_request_list_lock);

}



/**

 * parahotplug_request_complete() - mark request as complete

 * @id:     the id of the request
@@ -2091,6 +2059,37 @@ read_controlvm_event(struct controlvm_message *msg) 
	return false;

}



/**

 * parahotplug_process_list() - remove any request from the list that's been on

 *                              there too long and respond with an error

 */

static void

parahotplug_process_list(void)

{

	struct list_head *pos;

	struct list_head *tmp;



	spin_lock(&parahotplug_request_list_lock);



	list_for_each_safe(pos, tmp, &parahotplug_request_list) {

		struct parahotplug_request *req =

		    list_entry(pos, struct parahotplug_request, list);



		if (!time_after_eq(jiffies, req->expiration))

			continue;



		list_del(pos);

		if (req->msg.hdr.flags.response_expected)

			controlvm_respond_physdev_changestate(

				&req->msg.hdr,

				CONTROLVM_RESP_ERROR_DEVICE_UDEV_TIMEOUT,

				req->msg.cmd.device_change_state.state);

		parahotplug_request_destroy(req);

	}



	spin_unlock(&parahotplug_request_list_lock);

}



static void

controlvm_periodic_work(struct work_struct *work)

{