Commit a9f6a13d authored by Marijn Suijten's avatar Marijn Suijten Committed by Bjorn Andersson
Browse files

arm64: dts: qcom: sm6125-seine: Clean up gpio-keys (volume down) 



- Remove autorepeat (leave key repetition to userspace);
- Remove unneeded status = "okay" (this is the default);
- Remove unneeded linux,input-type <EV_KEY> (this is the default for
  gpio-keys);
- Allow the interrupt line for this button to be disabled;
- Use a full, descriptive node name;
- Set proper bias on the GPIO via pinctrl;
- Sort properties;
- Replace deprecated gpio-key,wakeup property with wakeup-source.

Fixes: 82e17838 ("arm64: dts: qcom: sm6125: Add support for Sony Xperia 10II")
Signed-off-by: default avatarMarijn Suijten <marijn.suijten@somainline.org>
Reviewed-by: default avatarKonrad Dybcio <konrad.dybcio@linaro.org>
Signed-off-by: default avatarBjorn Andersson <andersson@kernel.org>
Link: https://lore.kernel.org/r/20221222192443.119103-1-marijn.suijten@somainline.org
parent 581734f7

arch/arm64/boot/dts/qcom/sm6125-sony-xperia-seine-pdx201.dts

+14 −5
Original line number Diff line number Diff line
@@ -46,17 +46,18 @@ extcon_usb: extcon-usb { 
	};



	gpio-keys {

		status = "okay";

		compatible = "gpio-keys";

		autorepeat;



		key-vol-dn {

		pinctrl-0 = <&vol_down_n>;

		pinctrl-names = "default";



		key-volume-down {

			label = "Volume Down";

			gpios = <&tlmm 47 GPIO_ACTIVE_LOW>;

			linux,input-type = <1>;

			linux,code = <KEY_VOLUMEDOWN>;

			gpio-key,wakeup;

			debounce-interval = <15>;

			linux,can-disable;

			wakeup-source;

		};

	};
@@ -432,6 +433,14 @@ &sdhc_2 { 


&tlmm {

	gpio-reserved-ranges = <22 2>, <28 6>;



	vol_down_n: vol-down-n-state {

		pins = "gpio47";

		function = "gpio";

		drive-strength = <2>;

		bias-disable;

		input-enable;

	};

};



&usb3 {