Commit aae91d7b authored by Phillip Potter's avatar Phillip Potter Committed by Greg Kroah-Hartman
Browse files

staging: r8188eu: convert DBG_88E calls in core/rtw_iol.c 



Convert the DBG_88E macro calls in core/rtw_iol.c to use pr_debug
or netdev_dbg appropriately, as their information may be useful to
observers, and this gets the driver closer to the point of being
able to remove DBG_88E itself.

Some calls are at points in the call chain where use of dev_dbg or
netdev_dbg isn't possible due to lack of device pointer, so plain
pr_debug is appropriate here.

Signed-off-by: default avatarPhillip Potter <phil@philpotter.co.uk>
Link: https://lore.kernel.org/r/20220110090020.6800-4-phil@philpotter.co.uk


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 38c75bb1

drivers/staging/r8188eu/core/rtw_iol.c

+6 −4
Original line number Diff line number Diff line
@@ -12,13 +12,15 @@ struct xmit_frame *rtw_IOL_accquire_xmit_frame(struct adapter *adapter) 


	xmit_frame = rtw_alloc_xmitframe(pxmitpriv);

	if (!xmit_frame) {

		DBG_88E("%s rtw_alloc_xmitframe return null\n", __func__);

		netdev_dbg(adapter->pnetdev,

			   "rtw_alloc_xmitframe return null\n");

		return NULL;

	}



	xmitbuf = rtw_alloc_xmitbuf(pxmitpriv);

	if (!xmitbuf) {

		DBG_88E("%s rtw_alloc_xmitbuf return null\n", __func__);

		netdev_dbg(adapter->pnetdev,

			   "rtw_alloc_xmitbuf return null\n");

		rtw_free_xmitframe(pxmitpriv, xmit_frame);

		return NULL;

	}
@@ -49,8 +51,8 @@ int rtw_IOL_append_cmds(struct xmit_frame *xmit_frame, u8 *IOL_cmds, u32 cmd_len 


	/* check if the io_buf can accommodate new cmds */

	if (ori_len + cmd_len + 8 > MAX_XMITBUF_SZ) {

		DBG_88E("%s %u is large than MAX_XMITBUF_SZ:%u, can't accommodate new cmds\n",

			__func__, ori_len + cmd_len + 8, MAX_XMITBUF_SZ);

		pr_debug("%u is larger than MAX_XMITBUF_SZ:%u, can't accommodate new cmds\n",

			 ori_len + cmd_len + 8, MAX_XMITBUF_SZ);

		return _FAIL;

	}