Commit abb9088b authored by Fenglin Wu's avatar Fenglin Wu Committed by Greg Kroah-Hartman
Browse files

spmi: pmic-arb: handle spurious interrupt 



Call handle_bad_irq() when the summary interrupt is fired spuriously.

Signed-off-by: default avatarFenglin Wu <quic_fenglinw@quicinc.com>
Link: https://lore.kernel.org/r/1655004286-11493-3-git-send-email-quic_fenglinw@quicinc.com


Signed-off-by: default avatarStephen Boyd <sboyd@kernel.org>
Link: https://lore.kernel.org/r/20220930005019.2663064-4-sboyd@kernel.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 33c912d3

drivers/spmi/spmi-pmic-arb.c

+11 −3
Original line number Diff line number Diff line
@@ -605,10 +605,11 @@ static void cleanup_irq(struct spmi_pmic_arb *pmic_arb, u16 apid, int id) 
				irq_mask, ppid);

}



static void periph_interrupt(struct spmi_pmic_arb *pmic_arb, u16 apid)

static int periph_interrupt(struct spmi_pmic_arb *pmic_arb, u16 apid)

{

	unsigned int irq;

	u32 status, id;

	int handled = 0;

	u8 sid = (pmic_arb->apid_data[apid].ppid >> 8) & 0xF;

	u8 per = pmic_arb->apid_data[apid].ppid & 0xFF;
@@ -623,7 +624,10 @@ static void periph_interrupt(struct spmi_pmic_arb *pmic_arb, u16 apid) 
			continue;

		}

		generic_handle_irq(irq);

		handled++;

	}



	return handled;

}



static void pmic_arb_chained_irq(struct irq_desc *desc)
@@ -634,7 +638,7 @@ static void pmic_arb_chained_irq(struct irq_desc *desc) 
	int first = pmic_arb->min_apid >> 5;

	int last = pmic_arb->max_apid >> 5;

	u8 ee = pmic_arb->ee;

	u32 status, enable;

	u32 status, enable, handled = 0;

	int i, id, apid;



	chained_irq_enter(chip, desc);
@@ -649,10 +653,14 @@ static void pmic_arb_chained_irq(struct irq_desc *desc) 
			enable = readl_relaxed(

					ver_ops->acc_enable(pmic_arb, apid));

			if (enable & SPMI_PIC_ACC_ENABLE_BIT)

				periph_interrupt(pmic_arb, apid);

				if (periph_interrupt(pmic_arb, apid) != 0)

					handled++;

		}

	}



	if (handled == 0)

		handle_bad_irq(desc);



	chained_irq_exit(chip, desc);

}