Commit ac53e0f5 authored by Christophe JAILLET's avatar Christophe JAILLET Committed by Leon Romanovsky
Browse files

RDMA/qib: Use the bitmap API when applicable 

Using the bitmap API is less verbose than hand writing them.
It also improves the semantic.

While at it, initialize the bitmaps. It can't hurt.

Link: https://lore.kernel.org/r/33d8992586d382bec8b8efd83e4729fb7feaf89e.1656834106.git.christophe.jaillet@wanadoo.fr


Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: default avatarLeon Romanovsky <leon@kernel.org>
parent 2635d2a8

drivers/infiniband/hw/qib/qib_iba7322.c

+8 −15
Original line number Diff line number Diff line
@@ -2850,9 +2850,9 @@ static void qib_setup_7322_cleanup(struct qib_devdata *dd) 


	qib_7322_free_irq(dd);

	kfree(dd->cspec->cntrs);

	kfree(dd->cspec->sendchkenable);

	kfree(dd->cspec->sendgrhchk);

	kfree(dd->cspec->sendibchk);

	bitmap_free(dd->cspec->sendchkenable);

	bitmap_free(dd->cspec->sendgrhchk);

	bitmap_free(dd->cspec->sendibchk);

	kfree(dd->cspec->msix_entries);

	for (i = 0; i < dd->num_pports; i++) {

		unsigned long flags;
@@ -6383,18 +6383,11 @@ static int qib_init_7322_variables(struct qib_devdata *dd) 
	features = qib_7322_boardname(dd);



	/* now that piobcnt2k and 4k set, we can allocate these */

	sbufcnt = dd->piobcnt2k + dd->piobcnt4k +

		NUM_VL15_BUFS + BITS_PER_LONG - 1;

	sbufcnt /= BITS_PER_LONG;

	dd->cspec->sendchkenable =

		kmalloc_array(sbufcnt, sizeof(*dd->cspec->sendchkenable),

			      GFP_KERNEL);

	dd->cspec->sendgrhchk =

		kmalloc_array(sbufcnt, sizeof(*dd->cspec->sendgrhchk),

			      GFP_KERNEL);

	dd->cspec->sendibchk =

		kmalloc_array(sbufcnt, sizeof(*dd->cspec->sendibchk),

			      GFP_KERNEL);

	sbufcnt = dd->piobcnt2k + dd->piobcnt4k + NUM_VL15_BUFS;



	dd->cspec->sendchkenable = bitmap_zalloc(sbufcnt, GFP_KERNEL);

	dd->cspec->sendgrhchk = bitmap_zalloc(sbufcnt, GFP_KERNEL);

	dd->cspec->sendibchk = bitmap_zalloc(sbufcnt, GFP_KERNEL);

	if (!dd->cspec->sendchkenable || !dd->cspec->sendgrhchk ||

		!dd->cspec->sendibchk) {

		ret = -ENOMEM;