Commit ac67acd3 authored by Johan Hovold's avatar Johan Hovold Committed by Greg Kroah-Hartman
Browse files

greybus: operation: move message-header definition to header file 



Move operation message-header to operation.h so that it can be used
by host drivers.

Signed-off-by: default avatarJohan Hovold <johan@hovoldconsulting.com>
Reviewed-by: default avatarAlex Elder <elder@linaro.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@google.com>
parent cbba76f5

drivers/staging/greybus/operation.c

+0 −29
Original line number Diff line number Diff line
@@ -32,35 +32,6 @@ static struct workqueue_struct *gb_operation_workqueue; 
/* Protects the cookie representing whether a message is in flight */

static DEFINE_MUTEX(gb_message_mutex);



/*

 * All operation messages (both requests and responses) begin with

 * a header that encodes the size of the message (header included).

 * This header also contains a unique identifier, that associates a

 * response message with its operation.  The header contains an

 * operation type field, whose interpretation is dependent on what

 * type of protocol is used over the connection.  The high bit

 * (0x80) of the operation type field is used to indicate whether

 * the message is a request (clear) or a response (set).

 *

 * Response messages include an additional result byte, which

 * communicates the result of the corresponding request.  A zero

 * result value means the operation completed successfully.  Any

 * other value indicates an error; in this case, the payload of the

 * response message (if any) is ignored.  The result byte must be

 * zero in the header for a request message.

 *

 * The wire format for all numeric fields in the header is little

 * endian.  Any operation-specific data begins immediately after the

 * header, and is 64-bit aligned.

 */

struct gb_operation_msg_hdr {

	__le16	size;		/* Size in bytes of header + payload */

	__le16	operation_id;	/* Operation unique id */

	__u8	type;		/* E.g GB_I2C_TYPE_* or GB_GPIO_TYPE_* */

	__u8	result;		/* Result of request (in responses only) */

	/* 2 bytes pad, must be zero (ignore when read) */

} __aligned(sizeof(u64));



/*

 * Protects access to connection operations lists, as well as

 * updates to operation->errno.

drivers/staging/greybus/operation.h

+29 −0
Original line number Diff line number Diff line
@@ -40,6 +40,35 @@ enum gb_operation_result { 
	GB_OP_MALFUNCTION	= 0xff,

};



/*

 * All operation messages (both requests and responses) begin with

 * a header that encodes the size of the message (header included).

 * This header also contains a unique identifier, that associates a

 * response message with its operation.  The header contains an

 * operation type field, whose interpretation is dependent on what

 * type of protocol is used over the connection.  The high bit

 * (0x80) of the operation type field is used to indicate whether

 * the message is a request (clear) or a response (set).

 *

 * Response messages include an additional result byte, which

 * communicates the result of the corresponding request.  A zero

 * result value means the operation completed successfully.  Any

 * other value indicates an error; in this case, the payload of the

 * response message (if any) is ignored.  The result byte must be

 * zero in the header for a request message.

 *

 * The wire format for all numeric fields in the header is little

 * endian.  Any operation-specific data begins immediately after the

 * header, and is 64-bit aligned.

 */

struct gb_operation_msg_hdr {

	__le16	size;		/* Size in bytes of header + payload */

	__le16	operation_id;	/* Operation unique id */

	__u8	type;		/* E.g GB_I2C_TYPE_* or GB_GPIO_TYPE_* */

	__u8	result;		/* Result of request (in responses only) */

	/* 2 bytes pad, must be zero (ignore when read) */

} __aligned(sizeof(u64));



/*

 * Protocol code should only examine the payload and payload_size

 * fields.  All other fields are intended to be private to the