Commit ae382c22 authored by Oded Gabbay's avatar Oded Gabbay
Browse files

habanalabs: use strscpy instead of sprintf and strlcpy 



Prefer the use of strscpy when copying the ASIC name into a char array,
to prevent accidentally exceeding the array's length.
In addition, strlcpy is frowned upon so replace it.

Signed-off-by: default avatarOded Gabbay <ogabbay@kernel.org>
parent 131d1ba1

drivers/misc/habanalabs/common/device.c

+2 −2
Original line number Diff line number Diff line
@@ -321,11 +321,11 @@ static int device_early_init(struct hl_device *hdev) 
	switch (hdev->asic_type) {

	case ASIC_GOYA:

		goya_set_asic_funcs(hdev);

		strlcpy(hdev->asic_name, "GOYA", sizeof(hdev->asic_name));

		strscpy(hdev->asic_name, "GOYA", sizeof(hdev->asic_name));

		break;

	case ASIC_GAUDI:

		gaudi_set_asic_funcs(hdev);

		sprintf(hdev->asic_name, "GAUDI");

		strscpy(hdev->asic_name, "GAUDI", sizeof(hdev->asic_name));

		break;

	default:

		dev_err(hdev->dev, "Unrecognized ASIC type %d\n",