Commit aebcc159 authored by Christoph Hellwig's avatar Christoph Hellwig Committed by David Sterba
Browse files

btrfs: move setting the buffer uptodate out of validate_extent_buffer 



Setting the buffer uptodate in a function that is named as a validation
helper is a it confusing.  Move the call from validate_extent_buffer to
the one of its two callers that didn't already have a duplicate call
to set_extent_buffer_uptodate.

Reviewed-by: default avatarJohannes Thumshirn <johannes.thumshirn@wdc.com>
Reviewed-by: default avatarQu Wenruo <wqu@suse.com>
Reviewed-by: default avatarJosef Bacik <josef@toxicpanda.com>
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Reviewed-by: default avatarDavid Sterba <dsterba@suse.com>
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
parent 243984b3

fs/btrfs/disk-io.c

+3 −3
Original line number Diff line number Diff line
@@ -533,9 +533,7 @@ static int validate_extent_buffer(struct extent_buffer *eb, 
	if (found_level > 0 && btrfs_check_node(eb))

		ret = -EIO;



	if (!ret)

		set_extent_buffer_uptodate(eb);

	else

	if (ret)

		btrfs_err(fs_info,

		"read time tree block corruption detected on logical %llu mirror %u",

			  eb->start, eb->read_mirror);
@@ -627,6 +625,8 @@ int btrfs_validate_metadata_buffer(struct btrfs_bio *bbio, 
		goto err;

	}

	ret = validate_extent_buffer(eb, &bbio->parent_check);

	if (!ret)

		set_extent_buffer_uptodate(eb);

err:

	if (ret) {

		/*