Commit af84101e authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Florian Fainelli
Browse files

ARM: dts: broadcom: align LED node names with dtschema 



The node names should be generic and DT schema expects certain pattern:

  bcm4708-asus-rt-ac68u.dtb: leds: 'logo', 'power', 'usb2', 'usb3' do not match any of the regexes: '(^led-[0-9a-f]$|led)', 'pinctrl-[0-9]+'

Signed-off-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://lore.kernel.org/r/20221125144128.477059-1-krzysztof.kozlowski@linaro.org


Signed-off-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
parent 1156e3a7

arch/arm/boot/dts/bcm4708-asus-rt-ac56u.dts

+7 −8
Original line number Diff line number Diff line
@@ -28,40 +28,39 @@ memory@0 { 
	leds {

		compatible = "gpio-leds";



		usb3 {

		led-usb3 {

			label = "bcm53xx:blue:usb3";

			gpios = <&chipcommon 0 GPIO_ACTIVE_LOW>;

		};



		wan {

		led-wan {

			label = "bcm53xx:blue:wan";

			gpios = <&chipcommon 1 GPIO_ACTIVE_LOW>;

		};



		lan {

		led-lan {

			label = "bcm53xx:blue:lan";

			gpios = <&chipcommon 2 GPIO_ACTIVE_LOW>;

		};



		power {

		led-power {

			label = "bcm53xx:blue:power";

			gpios = <&chipcommon 3 GPIO_ACTIVE_LOW>;

			linux,default-trigger = "default-on";

		};



		all {

		led-all {

			label = "bcm53xx:blue:all";

			gpios = <&chipcommon 4 GPIO_ACTIVE_LOW>;

			linux,default-trigger = "default-on";

		};



		2ghz {

		led-2ghz {

			label = "bcm53xx:blue:2ghz";

			gpios = <&chipcommon 6 GPIO_ACTIVE_LOW>;

		};





		usb2 {

		led-usb2 {

			label = "bcm53xx:blue:usb2";

			gpios = <&chipcommon 14 GPIO_ACTIVE_LOW>;

		};

arch/arm/boot/dts/bcm4708-asus-rt-ac68u.dts

+4 −4
Original line number Diff line number Diff line
@@ -28,24 +28,24 @@ memory@0 { 
	leds {

		compatible = "gpio-leds";



		usb2 {

		led-usb2 {

			label = "bcm53xx:blue:usb2";

			gpios = <&chipcommon 0 GPIO_ACTIVE_LOW>;

		};



		power {

		led-power {

			label = "bcm53xx:blue:power";

			gpios = <&chipcommon 3 GPIO_ACTIVE_LOW>;

			linux,default-trigger = "default-on";

		};



		logo {

		led-logo {

			label = "bcm53xx:white:logo";

			gpios = <&chipcommon 4 GPIO_ACTIVE_LOW>;

			linux,default-trigger = "default-on";

		};



		usb3 {

		led-usb3 {

			label = "bcm53xx:blue:usb3";

			gpios = <&chipcommon 14 GPIO_ACTIVE_LOW>;

		};

arch/arm/boot/dts/bcm4708-buffalo-wzr-1166dhp-common.dtsi

+8 −8
Original line number Diff line number Diff line
@@ -37,7 +37,7 @@ hc595: gpio_spi@0 { 
	leds {

		compatible = "gpio-leds";



		usb {

		led-usb {

			/* label = "bcm53xx:blue:usb"; */

			function = LED_FUNCTION_USB;

			color = <LED_COLOR_ID_BLUE>;
@@ -48,14 +48,14 @@ usb { 
			linux,default-trigger = "usbport";

		};



		power0 {

		led-power0 {

			/* label = "bcm53xx:red:power"; */

			function = LED_FUNCTION_FAULT;

			color = <LED_COLOR_ID_RED>;

			gpios = <&hc595 1 GPIO_ACTIVE_HIGH>;

		};



		power1 {

		led-power1 {

			/* label = "bcm53xx:white:power"; */

			function = LED_FUNCTION_POWER;

			color = <LED_COLOR_ID_WHITE>;
@@ -63,7 +63,7 @@ power1 { 
			linux,default-trigger = "default-on";

		};



		router0 {

		led-router0 {

			/*  label = "bcm53xx:blue:router"; */

			function = LED_FUNCTION_STATUS;

			color = <LED_COLOR_ID_BLUE>;
@@ -71,14 +71,14 @@ router0 { 
			linux,default-trigger = "default-on";

		};



		router1 {

		led-router1 {

			/* label = "bcm53xx:amber:router"; */

			function = LED_FUNCTION_STATUS;

			color = <LED_COLOR_ID_AMBER>;

			gpios = <&hc595 4 GPIO_ACTIVE_HIGH>;

		};



		wan {

		led-wan {

			/* label = "bcm53xx:blue:wan"; */

			function = LED_FUNCTION_WAN;

			color = <LED_COLOR_ID_BLUE>;
@@ -86,14 +86,14 @@ wan { 
			linux,default-trigger = "default-on";

		};



		wireless0 {

		led-wireless0 {

			/* label = "bcm53xx:blue:wireless"; */

			function = LED_FUNCTION_WLAN;

			color = <LED_COLOR_ID_BLUE>;

			gpios = <&hc595 6 GPIO_ACTIVE_HIGH>;

		};



		wireless1 {

		led-wireless1 {

			/* label = "bcm53xx:amber:wireless"; */

			function = LED_FUNCTION_WLAN;

			color = <LED_COLOR_ID_AMBER>;

arch/arm/boot/dts/bcm4708-buffalo-wzr-1750dhp.dts

+8 −8
Original line number Diff line number Diff line
@@ -49,7 +49,7 @@ hc595: gpio_spi@0 { 
	leds {

		compatible = "gpio-leds";



		usb {

		led-usb {

			label = "bcm53xx:blue:usb";

			gpios = <&hc595 0 GPIO_ACTIVE_HIGH>;

			trigger-sources = <&ohci_port1>, <&ehci_port1>,
@@ -58,40 +58,40 @@ usb { 
			linux,default-trigger = "usbport";

		};



		power0 {

		led-power0 {

			label = "bcm53xx:red:power";

			gpios = <&hc595 1 GPIO_ACTIVE_HIGH>;

		};



		power1 {

		led-power1 {

			label = "bcm53xx:white:power";

			gpios = <&hc595 2 GPIO_ACTIVE_HIGH>;

			linux,default-trigger = "default-on";

		};



		router0 {

		led-router0 {

			label = "bcm53xx:blue:router";

			gpios = <&hc595 3 GPIO_ACTIVE_HIGH>;

			linux,default-trigger = "default-on";

		};



		router1 {

		led-router1 {

			label = "bcm53xx:amber:router";

			gpios = <&hc595 4 GPIO_ACTIVE_HIGH>;

		};



		wan {

		led-wan {

			label = "bcm53xx:blue:wan";

			gpios = <&hc595 5 GPIO_ACTIVE_HIGH>;

			linux,default-trigger = "default-on";

		};



		wireless0 {

		led-wireless0 {

			label = "bcm53xx:blue:wireless";

			gpios = <&hc595 6 GPIO_ACTIVE_HIGH>;

		};



		wireless1 {

		led-wireless1 {

			label = "bcm53xx:amber:wireless";

			gpios = <&hc595 7 GPIO_ACTIVE_HIGH>;

		};

arch/arm/boot/dts/bcm4708-luxul-xap-1510.dts

+3 −3
Original line number Diff line number Diff line
@@ -23,19 +23,19 @@ memory@0 { 
	leds {

		compatible = "gpio-leds";



		5ghz {

		led-5ghz {

			label = "bcm53xx:blue:5ghz";

			gpios = <&chipcommon 13 GPIO_ACTIVE_LOW>;

			linux,default-trigger = "none";

		};



		2ghz {

		led-2ghz {

			label = "bcm53xx:blue:2ghz";

			gpios = <&chipcommon 14 GPIO_ACTIVE_LOW>;

			linux,default-trigger = "none";

		};



		status {

		led-status {

			label = "bcm53xx:green:status";

			gpios = <&chipcommon 15 GPIO_ACTIVE_LOW>;

			linux,default-trigger = "timer";