Commit b01c1e02 authored by xingtong.wu's avatar xingtong.wu Committed by Hans de Goede
Browse files

platform/x86/siemens: simatic-ipc: fix logical error for BX-59A 



The variable "ledmode" is missing from if statement that leads to
a logical error. Add the missing variable to the if condition.

Fixes: b8af7795 ("platform/x86/siemens: simatic-ipc: add new models BX-56A/BX-59A")
Reported-by: default avatarkernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202307312322.Aa8upHWK-lkp@intel.com/


Reviewed-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: default avatarxingtong.wu <xingtong.wu@siemens.com>
Link: https://lore.kernel.org/r/20430802173515.2363-2-xingtong_wu@163.com


Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
parent e5d5ffa4

drivers/platform/x86/siemens/simatic-ipc.c

+1 −1
Original line number Diff line number Diff line
@@ -129,7 +129,7 @@ static int register_platform_devices(u32 station_id) 
		pdevname = KBUILD_MODNAME "_leds";

		if (ledmode == SIMATIC_IPC_DEVICE_127E)

			pdevname = KBUILD_MODNAME "_leds_gpio_apollolake";

		if (ledmode == SIMATIC_IPC_DEVICE_227G || SIMATIC_IPC_DEVICE_BX_59A)

		if (ledmode == SIMATIC_IPC_DEVICE_227G || ledmode == SIMATIC_IPC_DEVICE_BX_59A)

			pdevname = KBUILD_MODNAME "_leds_gpio_f7188x";

		if (ledmode == SIMATIC_IPC_DEVICE_BX_21A)

			pdevname = KBUILD_MODNAME "_leds_gpio_elkhartlake";