Commit b202d4e8 authored by Christophe JAILLET's avatar Christophe JAILLET Committed by Vinod Koul
Browse files

dmaengine: fsldma: Fix a resource leak in an error handling path of the probe function 



In case of error, the previous 'fsl_dma_chan_probe()' calls must be undone
by some 'fsl_dma_chan_remove()', as already done in the remove function.

It was added in the remove function in commit 77cd62e8 ("fsldma: allow
Freescale Elo DMA driver to be compiled as a module")

Fixes: d3f620b2 ("fsldma: simplify IRQ probing and handling")
Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/20201212160614.92576-1-christophe.jaillet@wanadoo.fr


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent cbc0ad00

drivers/dma/fsldma.c

+5 −0
Original line number Diff line number Diff line
@@ -1214,6 +1214,7 @@ static int fsldma_of_probe(struct platform_device *op) 
{

	struct fsldma_device *fdev;

	struct device_node *child;

	unsigned int i;

	int err;



	fdev = kzalloc(sizeof(*fdev), GFP_KERNEL);
@@ -1292,6 +1293,10 @@ static int fsldma_of_probe(struct platform_device *op) 
	return 0;



out_free_fdev:

	for (i = 0; i < FSL_DMA_MAX_CHANS_PER_DEVICE; i++) {

		if (fdev->chan[i])

			fsl_dma_chan_remove(fdev->chan[i]);

	}

	irq_dispose_mapping(fdev->irq);

	iounmap(fdev->regs);

out_free: