Commit b235f371 authored by Dan Carpenter's avatar Dan Carpenter Committed by Steve French
Browse files

cifs: cifs_convert_address() returns zero on error 



The cifs_convert_address() returns zero on error but this caller is
testing for negative returns.

Btw. "i" is unsigned here, so it's never negative.

Reviewed-by: default avatarJeff Layton <jlayton@samba.org>
Signed-off-by: default avatarDan Carpenter <error27@gmail.com>
Signed-off-by: default avatarSteve French <sfrench@us.ibm.com>
parent 21e73393

fs/cifs/connect.c

+1 −1
Original line number Diff line number Diff line
@@ -1067,7 +1067,7 @@ cifs_parse_mount_options(char *options, const char *devname, 
			}

			i = cifs_convert_address((struct sockaddr *)&vol->srcaddr,

						 value, strlen(value));

			if (i < 0) {

			if (i == 0) {

				printk(KERN_WARNING "CIFS:  Could not parse"

				       " srcaddr: %s\n",

				       value);