Commit b3916da0 authored by Kemeng Shi's avatar Kemeng Shi Committed by Theodore Ts'o
Browse files

ext4: fix wrong unit use in ext4_mb_normalize_request 



NRL_CHECK_SIZE will compare input req and size, so req and size should
be in same unit. Input req "fe_len" is in cluster unit while input
size "(8<<20)>>bsbits" is in block unit. Convert "fe_len" to block
unit to fix the mismatch.

Signed-off-by: default avatarKemeng Shi <shikemeng@huaweicloud.com>
Reviewed-by: default avatarOjaswin Mujoo <ojaswin@linux.ibm.com>
Link: https://lore.kernel.org/r/20230603150327.3596033-2-shikemeng@huaweicloud.com


Signed-off-by: default avatarTheodore Ts'o <tytso@mit.edu>
parent 0dea40aa

fs/ext4/mballoc.c

+1 −1
Original line number Diff line number Diff line
@@ -4283,7 +4283,7 @@ ext4_mb_normalize_request(struct ext4_allocation_context *ac, 
		start_off = ((loff_t)ac->ac_o_ex.fe_logical >>

							(22 - bsbits)) << 22;

		size = 4 * 1024 * 1024;

	} else if (NRL_CHECK_SIZE(ac->ac_o_ex.fe_len,

	} else if (NRL_CHECK_SIZE(EXT4_C2B(sbi, ac->ac_o_ex.fe_len),

					(8<<20)>>bsbits, max, 8 * 1024)) {

		start_off = ((loff_t)ac->ac_o_ex.fe_logical >>

							(23 - bsbits)) << 23;