Commit b4b700c5 authored by Seth Jennings's avatar Seth Jennings Committed by Greg Kroah-Hartman
Browse files

staging: zsmalloc: fix uninit'ed variable warning 



This patch fixes an uninitialized variable warning in
alloc_zspage().  It also fixes the secondary issue of
prev_page leaving scope on each loop iteration.  The only
reason this ever worked was because prev_page was occupying
the same space on the stack on each iteration.

Signed-off-by: default avatarSeth Jennings <sjenning@linux.vnet.ibm.com>
Reported-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 03ae8189

drivers/staging/zsmalloc/zsmalloc-main.c

+2 −2
Original line number Diff line number Diff line
@@ -400,7 +400,7 @@ static void init_zspage(struct page *first_page, struct size_class *class) 
static struct page *alloc_zspage(struct size_class *class, gfp_t flags)

{

	int i, error;

	struct page *first_page = NULL;

	struct page *first_page = NULL, *uninitialized_var(prev_page);



	/*

	 * Allocate individual pages and link them together as:
@@ -415,7 +415,7 @@ static struct page *alloc_zspage(struct size_class *class, gfp_t flags) 
	 */

	error = -ENOMEM;

	for (i = 0; i < class->pages_per_zspage; i++) {

		struct page *page, *prev_page;

		struct page *page;



		page = alloc_page(flags);

		if (!page)