Commit b5d9209d authored by Wei Yongjun's avatar Wei Yongjun Committed by Lorenzo Pieralisi
Browse files

PCI: brcmstb: Fix error return code in brcm_pcie_probe() 

Fix to return negative error code -ENODEV from the unsupported revision
error handling case instead of 0, as done elsewhere in this function.

Link: https://lore.kernel.org/r/20210308135619.19133-1-weiyongjun1@huawei.com


Fixes: 0cdfaceb ("PCI: brcmstb: support BCM4908 with external PERST# signal controller")
Reported-by: default avatarHulk Robot <hulkci@huawei.com>
Signed-off-by: default avatarWei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: default avatarLorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Reviewed-by: default avatarKrzysztof Wilczyński <kw@linux.com>
Acked-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
parent a38fd874

drivers/pci/controller/pcie-brcmstb.c

+1 −0
Original line number Diff line number Diff line
@@ -1296,6 +1296,7 @@ static int brcm_pcie_probe(struct platform_device *pdev) 
	pcie->hw_rev = readl(pcie->base + PCIE_MISC_REVISION);

	if (pcie->type == BCM4908 && pcie->hw_rev >= BRCM_PCIE_HW_REV_3_20) {

		dev_err(pcie->dev, "hardware revision with unsupported PERST# setup\n");

		ret = -ENODEV;

		goto fail;

	}