Commit b674bcb1 authored by Liang He's avatar Liang He Committed by Guenter Roeck
Browse files

hwmon: (gsc-hwmon) Add missing of_node_put() 



In gsc_hwmon_get_devtree_pdata(), of_find_compatible_node() will return
a node pointer with refcount incremented. We should use of_node_put() in
fail path or when it is not used anymore.

Signed-off-by: default avatarLiang He <windhl@126.com>
Link: https://lore.kernel.org/r/20220616114024.3985770-1-windhl@126.com


Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent 489dd8f0

drivers/hwmon/gsc-hwmon.c

+3 −0
Original line number Diff line number Diff line
@@ -269,10 +269,13 @@ gsc_hwmon_get_devtree_pdata(struct device *dev) 
	/* fan controller base address */

	fan = of_find_compatible_node(dev->parent->of_node, NULL, "gw,gsc-fan");

	if (fan && of_property_read_u32(fan, "reg", &pdata->fan_base)) {

		of_node_put(fan);

		dev_err(dev, "fan node without base\n");

		return ERR_PTR(-EINVAL);

	}



	of_node_put(fan);



	/* allocate structures for channels and count instances of each type */

	device_for_each_child_node(dev, child) {

		if (fwnode_property_read_string(child, "label", &ch->name)) {