Commit b680cb9b authored by Jeff Layton's avatar Jeff Layton Committed by Chuck Lever
Browse files

nfsd: add some comments to nfsd_file_do_acquire 



David Howells mentioned that he found this bit of code confusing, so
sprinkle in some comments to clarify.

Reported-by: default avatarDavid Howells <dhowells@redhat.com>
Signed-off-by: default avatarJeff Layton <jlayton@kernel.org>
Signed-off-by: default avatarChuck Lever <chuck.lever@oracle.com>
parent c6593366

fs/nfsd/filecache.c

+5 −0
Original line number Original line Diff line number Diff line
@@ -1094,6 +1094,11 @@ nfsd_file_do_acquire(struct svc_rqst *rqstp, struct svc_fh *fhp, 
	rcu_read_unlock();

	rcu_read_unlock();





	if (nf) {

	if (nf) {

		/*

		 * If the nf is on the LRU then it holds an extra reference

		 * that must be put if it's removed. It had better not be

		 * the last one however, since we should hold another.

		 */

		if (nfsd_file_lru_remove(nf))

		if (nfsd_file_lru_remove(nf))

			WARN_ON_ONCE(refcount_dec_and_test(&nf->nf_ref));

			WARN_ON_ONCE(refcount_dec_and_test(&nf->nf_ref));

		goto wait_for_construction;

		goto wait_for_construction;