Commit b6fdbbb7 authored by Todd Poynor's avatar Todd Poynor Committed by Greg Kroah-Hartman
Browse files

staging: gasket: remove code for no physical device 



gasket_enable_dev code for enabling a gasket device with no physical PCI
device registered shouldn't be necessary.

Reported-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarTodd Poynor <toddpoynor@google.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 7a013c50

drivers/staging/gasket/gasket_core.c

+1 −11
Original line number Diff line number Diff line
@@ -898,7 +898,6 @@ static int gasket_enable_dev( 
{

	int tbl_idx;

	int ret;

	struct device *ddev;

	const struct gasket_driver_desc *driver_desc =

		internal_desc->driver_desc;
@@ -919,21 +918,12 @@ static int gasket_enable_dev( 
	for (tbl_idx = 0; tbl_idx < driver_desc->num_page_tables; tbl_idx++) {

		gasket_log_debug(

			gasket_dev, "Initializing page table %d.", tbl_idx);

		if (gasket_dev->pci_dev) {

			ddev = &gasket_dev->pci_dev->dev;

		} else {

			gasket_log_error(

				gasket_dev,

				"%s with no physical device!!", __func__);

			WARN_ON(1);

			ddev = NULL;

		}

		ret = gasket_page_table_init(

			&gasket_dev->page_table[tbl_idx],

			&gasket_dev->bar_data[

				driver_desc->page_table_bar_index],

			&driver_desc->page_table_configs[tbl_idx],

			ddev, gasket_dev->pci_dev, true);

			&gasket_dev->pci_dev->dev, gasket_dev->pci_dev, true);

		if (ret) {

			gasket_log_error(

				gasket_dev,